Comment on attachment 8888024 [details] Bug 1382331 - Redesign histograms in about:telemetry https://reviewboard.mozilla.org/r/158892/#review164322 ::: commit-message-1b065:2 (Diff revision 1) > +Bug 1382331 - Redesign histograms in about:telemetry r?chutten > + Need some explanantion about "how" you redesigned them, maybe a bit on "why" as well. ::: toolkit/content/aboutTelemetry.js:1354 (Diff revision 1) > bar.style.height = belowEm + "em"; > barDiv.appendChild(bar); > > // Add bucket label > + if (label.length > 3) { > + if (previousLongLabel) { I don't understand this... you want to mark only some long labels as long? To what end? There's no style that I see in this patch for .long-label

Comment on attachment 8888024 [details] Bug 1382331 - Redesign histograms in about:telemetry https://reviewboard.mozilla.org/r/158892/#review165294

Comment on attachment 8888024 [details] Bug 1382331 - Redesign histograms in about:telemetry https://reviewboard.mozilla.org/r/158892/#review165788 LGTM

Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/bd140659a6b7 Redesign histograms in about:telemetry r=chutten

Backed out for eslint failure at aboutTelemetry.js:1353: Strings must use doublequote: https://hg.mozilla.org/integration/autoland/rev/b84484d5c6d57205e38121ddd5ffffbce25f09c7 Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=bd140659a6b7739cb9cef76a01ceec1a749c2e4a&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=117042176&repo=autoland > TEST-UNEXPECTED-ERROR | /home/worker/checkouts/gecko/toolkit/content/aboutTelemetry.js:1353:29 | Strings must use doublequote. (quotes)

Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/0f63a6b51c1b Redesign histograms in about:telemetry r=chutten