Closed
Bug 1382382
Opened 7 years ago
Closed 7 years ago
Songsterr tab player green marker disappears using HWA
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: bram.speeckaert, Assigned: dvander)
References
Details
Attachments
(1 file)
(deleted),
patch
|
mattwoodrow
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0
Build ID: 20170719030206
Steps to reproduce:
1) Open https://www.songsterr.com/a/wsa/tears-for-fears-everybody-wants-to-rule-the-world-tab-s19814t1
2) Wait for it to finish loading and hit play on the right.
Actual results:
The green marker moving over the song regularly disappears when HWA is on.
Expected results:
The green marker should remain visible, as it does in other browsers and with HWA off.
Updated•7 years ago
|
Component: Untriaged → Audio/Video: Playback
Product: Firefox → Core
Comment 1•7 years ago
|
||
Whst do you mean by HWA being on?
Is this site playing a video?
Flags: needinfo?(bram.speeckaert)
Reporter | ||
Comment 2•7 years ago
|
||
By HWA I meant hardware acceleration.
It's not playing a video. One of the Graphics components is probably more appropriate here.
Flags: needinfo?(bram.speeckaert)
Comment 3•7 years ago
|
||
It's not playback then.
At this stage I'll assume it's graphics.
Component: Audio/Video: Playback → Graphics
Comment 4•7 years ago
|
||
Still wondering what.made you assume it was a Hwa issue.
Eg. One step to reproduce without the problem appearing, and one with the problem.
Flags: needinfo?(bram.speeckaert)
Reporter | ||
Comment 5•7 years ago
|
||
You can toggle hardware acceleration on about:preferences in the 'General' settings under 'Performance'. First uncheck 'Use recommended performance settings', then check/uncheck 'Use hardware acceleration when available'. I think you need to restart the browser before the setting takes effect, so make sure you do that.
Do note that hardware acceleration may not be available depending on your hardware/platform.
Flags: needinfo?(bram.speeckaert)
Reporter | ||
Comment 6•7 years ago
|
||
Can no longer reproduce this after upgrading to 20170722030204.
Reporter | ||
Comment 7•7 years ago
|
||
Now it's happening again for me on 20170723030206. I suspect it wasn't gone from 20170722030204 at all, but that there's another factor that triggers the bug that I'm overlooking. I'll try to do more thorough testing.
Comment 8•7 years ago
|
||
I confirmed that the problem happened on latest nightly. It seems like AdvancedLayer specific bug. When I set "layers.mlgpu.dev-enabled" from about:config, the problem did not happen.
Comment 9•7 years ago
|
||
(In reply to Sotaro Ikeda [:sotaro] from comment #8)
> I confirmed that the problem happened on latest nightly. It seems like
> AdvancedLayer specific bug. When I set "layers.mlgpu.dev-enabled" from
> about:config, the problem did not happen.
Correction:
When I set "layers.mlgpu.dev-enabled" to false from about:config, the problem did not happen.
Comment 10•7 years ago
|
||
Bug 1381666 might be a related bug.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → dvander
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Flags: needinfo?(dvander)
Assignee | ||
Comment 12•7 years ago
|
||
Advanced Layers was assuming that it could skip over container layers if their visible bounds didn't overlap with the invalid region. The idea is we could skip recursing down large subtrees.
Unfortunately it doesn't work since visible regions on containers are not updated for async transforms or animations. We do recompute the bounds of containers with intermediate surfaces, but not pass-through containers.
We could tweak this optimization to only apply to fixed-up containers, or we could fix-up all containers... but instead, let's just remove it for now. I doubt it buys us much.
Attachment #8893075 -
Flags: review?(matt.woodrow)
Updated•7 years ago
|
Attachment #8893075 -
Flags: review?(matt.woodrow) → review+
Comment 13•7 years ago
|
||
Pushed by danderson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e9de905b23fa
Always visit children of container layers, in case they have asynchronous animations outside of the precomputed visible bounds. (bug 1382382, r=mattwoodrow)
Comment 14•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•