Closed
Bug 1382658
Opened 7 years ago
Closed 7 years ago
Label dispatches from imgRequestProxy::Cancel
Categories
(Core :: Graphics: ImageLib, enhancement, P3)
Core
Graphics: ImageLib
Tracking
()
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: aosmond, Assigned: aosmond)
References
Details
(Whiteboard: [gfx-noted])
Attachments
(1 file, 1 obsolete file)
imgRequestProxy::Cancel and imgRequestProxy::CancelAndForgetObserver call NS_DispatchToCurrentThread. These need to switch to our labelled event target (if available).
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → aosmond
Blocks: 1350938
Status: NEW → ASSIGNED
Priority: -- → P3
Whiteboard: [gfx-noted]
|
|
Assignee | |
Comment 1•7 years ago
|
||
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8888317 -
Flags: review?(tnikkel)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8888317 [details] [diff] [review]
imgRequestProxy::DoRemoveFromLoadGroup and imgCancelRunnable should be dispatched on labelled group if possible., v1
The name of the new function is kinda confusing, but I don't have a better idea.
Attachment #8888317 -
Flags: review?(tnikkel) → review+
|
|
Assignee | |
Comment 3•7 years ago
|
||
I renamed Dispatch to DispatchWithTarget (will assert it has a target) and DispatchExpected to DispatchWithTargetIfAvailable (will use it if available, else use unlabelled).
Attachment #8888317 -
Attachment is obsolete: true
Attachment #8897385 -
Flags: review+
Pushed by aosmond@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/89f97a79f232
imgRequestProxy::DoRemoveFromLoadGroup and imgCancelRunnable should be dispatched on labelled group if possible. r=tnikkel
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•