Closed
Bug 1382898
Opened 7 years ago
Closed 7 years ago
Disable the Stop / Reload animation if the stop / reload buttons are placed outside of the nav-bar
Categories
(Firefox :: Toolbars and Customization, enhancement, P1)
Firefox
Toolbars and Customization
Tracking
()
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: jaws, Assigned: jaws)
References
(Depends on 1 open bug)
Details
(Whiteboard: [reserve-photon-animation])
Attachments
(1 file)
Bug 1363485 will be adding the capability for moving the stop/reload button to an arbitrary location. However due to bug 1382894 we cannot run our animations outside of the nav-bar. This bug is on file to disable the animations for the stop/reload button if they are not in the nav-bar.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8888586 [details] Bug 1382898 - Disable the Stop / Reload animation if the stop / reload buttons are placed outside of the nav-bar due to bug 1382894. https://reviewboard.mozilla.org/r/159570/#review165094 rs=me
Attachment #8888586 -
Flags: review?(gijskruitbosch+bugs) → review+
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8888586 [details] Bug 1382898 - Disable the Stop / Reload animation if the stop / reload buttons are placed outside of the nav-bar due to bug 1382894. https://reviewboard.mozilla.org/r/159570/#review165132 ::: browser/themes/shared/toolbarbutton-icons.inc.css:52 (Diff revision 1) > +/* The animations for the reload-button and stop-button are disabled > + outside of the nav-bar due to bug 1382894. */ > +:-moz-any(#reload-button, #stop-button) > .toolbarbutton-animatable-box { > + display: none; > +} > +#nav-bar :-moz-any(#reload-button, #stop-button) > .toolbarbutton-animatable-box { Please use #nav-bar-customization-target and the child selector here.
Comment hidden (mozreview-request) |
Updated•7 years ago
|
Iteration: --- → 56.4 - Aug 1
Flags: qe-verify?
Priority: -- → P1
Whiteboard: [reserve-photon-animation]
Updated•7 years ago
|
Flags: qe-verify? → qe-verify+
QA Contact: jwilliams
Updated•7 years ago
|
Iteration: 56.4 - Aug 1 → 57.1 - Aug 15
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 9•7 years ago
|
||
Comment on attachment 8888586 [details] Bug 1382898 - Disable the Stop / Reload animation if the stop / reload buttons are placed outside of the nav-bar due to bug 1382894. Gijs, can you please re-review this patch? I had to add some code to browser.js to not add the "animate" attribute if the button was placed outside of the nav-bar. Without this code, if the button was placed in the tabs toolbar, next a page refreshed, then the button moved to the nav-bar, it would have the animate="true" attribute when no page load is occurring.
Attachment #8888586 -
Flags: review+ → review?(gijskruitbosch+bugs)
Comment 10•7 years ago
|
||
mozreview-review |
Comment on attachment 8888586 [details] Bug 1382898 - Disable the Stop / Reload animation if the stop / reload buttons are placed outside of the nav-bar due to bug 1382894. https://reviewboard.mozilla.org/r/159570/#review169812 Good catch, thanks!
Attachment #8888586 -
Flags: review?(gijskruitbosch+bugs) → review+
Comment 11•7 years ago
|
||
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. hg error in cmd: hg rebase -s c268ecb818a9 -d db11ec58efb6: rebasing 411386:c268ecb818a9 "Bug 1382898 - Disable the Stop / Reload animation if the stop / reload buttons are placed outside of the nav-bar due to bug 1382894. r=Gijs" (tip) merging browser/base/content/browser.js warning: conflicts while merging browser/base/content/browser.js! (edit, then use 'hg resolve --mark') unresolved conflicts (see hg resolve, then hg rebase --continue)
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 14•7 years ago
|
||
Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cdc0c0802e54 Disable the Stop / Reload animation if the stop / reload buttons are placed outside of the nav-bar due to bug 1382894. r=Gijs
Comment 15•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/cdc0c0802e54
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Updated•7 years ago
|
QA Contact: jwilliams → stefan.georgiev
Comment 16•7 years ago
|
||
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0 Build ID 20170905100117 This bug fix is Verified with latest Nightly 57.0a1. The the stop / reload button animation is disabled when the button is placed outside of the nav-bar.
Status: RESOLVED → VERIFIED
Updated•7 years ago
|
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•