Closed
Bug 1382908
Opened 7 years ago
Closed 7 years ago
Fix TaskTracer build
Categories
(Core :: Gecko Profiler, defect)
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox-esr52 | --- | unaffected |
| firefox54 | --- | wontfix |
| firefox55 | --- | wontfix |
| firefox56 | --- | fixed |
People
(Reporter: mstange, Assigned: mstange)
References
Details
(Keywords: regression)
Attachments
(1 file)
--enable-tasktracer is currently broken because TracedRunnable inherits from mozilla::Runnable but tries to call an argument-free constructor of Runnable which doesn't exist any more since bug 1331804.
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8888601 [details]
Bug 1382908 - Make TaskTracer build and run again.
https://reviewboard.mozilla.org/r/159600/#review165306
::: tools/profiler/tasktracer/TracedTaskCommon.h:64
(Diff revision 1)
>
> class TracedRunnable : public TracedTaskCommon
> - , public Runnable
> + , public nsIRunnable
> {
> public:
> + NS_DECL_ISUPPORTS
This needs to be THREADSAFE_ISUPPORTS.
Attachment #8888601 -
Flags: review?(wmccloskey) → review+
|
||
Updated•7 years ago
|
| Comment hidden (mozreview-request) |
|
||
Comment 4•7 years ago
|
||
We are one week from 55 RC. Mark 54 won't fix.
Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/e0dace2b0ab3
Make TaskTracer build and run again. r=billm
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
|
||
Updated•7 years ago
|
status-firefox-esr52:
--- → unaffected
Version: Trunk → 54 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•