Closed Bug 1383209 Opened 7 years ago Closed 6 years ago

Debugger doesn't scroll to the right line when clicking errors in the console

Categories

(DevTools :: Debugger, defect, P2)

Product:
DevTools
Component:
Debugger
Type:
defect

Tracking

(firefox-esr52 fix-optional)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox-esr52 --- fix-optional

People

(Reporter: bzbarsky, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

JS for testcase
(deleted), application/x-javascript
Details
Testcase
(deleted), text/html
Details
BUILD: 2017-07-21 Mac Nightly. STEPS TO REPRODUCE: 1) Load the testcase I'm about to attach in a clean profile. 2) Cmd+Option+K to open the console. 3) Click the link on the "ReferenceError" line (linking to line 1201 of the JS file). ACTUAL RESULTS: Debugger opens, loads JS file, does NOT scroll to the line. EXPECTED RESULTS: Scroll to the line and select it. This works fine with the old debugger frontend. ADDITIONAL INFORMATION: If the debugger is already open when loading the testcase, then scrolling to the line does work, but it doesn't get highlighted (unlike with the old debugger frontend). This bug makes debugging errors really annoying.
Attached file JS for testcase (deleted) —
Attached file Testcase (deleted) —
I'm getting the correct behaviour when I click the console error a second time. i.e. once the debugger is open and has the file loaded. But on first / fresh load it doesn't work correctly.
This fixes the issue with scrolling to the correct location: https://github.com/devtools-html/debugger.html/pull/3431 There's a secondary question of showing view-source or the debugger. This question is server side as the debugger server needs to get the source synchronously when asked.
Severity: major → normal
Priority: -- → P2
I tested it and am still seeing the issue where the debugger does not scroll to the correct line
Product: Firefox → DevTools

David, can you see if you can reproduce this? If so, maybe we should budget it for quality work this quarter...

Flags: needinfo?(dwalsh)

I tested this again; we have a problem that's "in the way" of truly testing this, and said problem is that clicking the reference error link opens "view-source:https://bug1383209.bmoattachments.org/attachment.cgi?id=8888882" in a new tab instead of opening the error in the debugger. The link's tooltip, however, says "View Source in Debugger -> {link address}", so we need to (1) determine what behavior we want here and (2) if it is to open the debugger, find out if this issue still exists.

:digitarald: What would you like to happen? I think that's what we need to ensure this is expected behavior.

Flags: needinfo?(dwalsh) → needinfo?(hkirschner)

in a new tab instead of opening the error in the debugger

I don't see your behavior. Opens in Debugger for me in Nightly (66.0a1 (2019-01-24) (64-bit)) and scrolls to the right line.

Unrelated feedback for follow up bugs: Comparing to Chrome, they do a better job at showing a slower fading highlight and marking the line up with an error styling + icon.

Flags: needinfo?(hkirschner)

Retested this and it appears to work great. Closing.

Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Blocks: 1565711
Blocks: 1565713
No longer blocks: 1565711
No longer blocks: 1565713
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: