Closed
Bug 1383395
Opened 7 years ago
Closed 7 years ago
Remove a useless check in nsCSSRendering.cpp
Categories
(Core :: Web Painting, enhancement)
Core
Web Painting
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: michael.scott250+mozilla)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, good-first-bug, Whiteboard: [good first bug][lang=C++][CID 1412664])
Attachments
(1 file)
https://dxr.mozilla.org/mozilla-central/source/layout/painting/nsCSSRendering.cpp?q=nsCSSRendering.cpp&redirect_type=direct#2643
if (!drawBackgroundImage) {
is useless as we have already done it
https://dxr.mozilla.org/mozilla-central/source/layout/painting/nsCSSRendering.cpp?q=nsCSSRendering.cpp&redirect_type=direct#2606
with a return
|
Assignee | |
Comment 1•7 years ago
|
||
I'd like to pick this up, seems fairly straightforward.
| Comment hidden (mozreview-request) |
Comment on attachment 8889141 [details]
Bug 1383395 - Remove an un-needed check for draw background image.
https://reviewboard.mozilla.org/r/160250/#review165518
thanks for fixing it
Attachment #8889141 -
Flags: review?(cku) → review+
|
Reporter | |
Updated•7 years ago
|
Assignee: nobody → michael.scott250+mozilla
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ef7a9d523ce4
Remove an un-needed check for draw background image. r=cjku
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
|
|
Assignee | |
Comment 6•7 years ago
|
||
Thanks for reviewing the change and merging it in!
|
||
Updated•7 years ago
|
status-firefox57:
affected → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•