Closed
Bug 1383908
Opened 7 years ago
Closed 7 years ago
Sidebar context menu is failing
Categories
(WebExtensions :: Frontend, defect, P1)
Tracking
(firefox56 fixed)
People
(Reporter: mixedpuppy, Assigned: mixedpuppy)
References
Details
Attachments
(1 file)
open a sidebar, use the context menu. every item is enabled. console has:
JavaScript error: resource:///modules/CustomizableUI.jsm, line 1368: Error: buildWidget was called for a non-browser window!
JavaScript error: chrome://browser/content/webext-panels.xul?panel=moz-extension%3A%2F%2F37c1a7d0-db5c-c145-a851-61e5f37cf839%2Fpage.html&remote=1&browser-style=1, line 1: TypeError: gContextMenu is null
Assignee | ||
Updated•7 years ago
|
webextensions: --- → ?
Comment hidden (mozreview-request) |
Updated•7 years ago
|
Attachment #8889671 -
Flags: review?(mconley) → review?(gijskruitbosch+bugs)
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8889671 [details]
Bug 1383908 check if we're running in a main window before using CUI,
https://reviewboard.mozilla.org/r/160738/#review166264
::: browser/base/content/browser-social.js:365
(Diff revision 1)
>
> get shareButton() {
> // web-panels (bookmark/sidebar) don't include customizableui, so
> // nsContextMenu fails when accessing shareButton, breaking
> // browser_bug409481.js.
> - if (!window.CustomizableUI)
> + if (document.documentElement.getAttribute("id") !== "main-window")
Please check `document.documentElement.getAttribute("windowtype")` against `navigator:browser` instead.
With that, r=me.
Attachment #8889671 -
Flags: review?(gijskruitbosch+bugs) → review+
Comment hidden (mozreview-request) |
Pushed by mixedpuppy@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/39b5cf816c13
check if we're running in a main window before using CUI, r=Gijs
Comment 5•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Updated•6 years ago
|
Product: Toolkit → WebExtensions
You need to log in
before you can comment on or make changes to this bug.
Description
•