Closed
Bug 1384044
Opened 7 years ago
Closed 7 years ago
Stop using preprocessor in osfile.jsm
Categories
(Toolkit Graveyard :: OS.File, enhancement)
Toolkit Graveyard
OS.File
Tracking
(firefox56 fixed)
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: marco, Assigned: marco)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
Yoric
:
review+
|
Details | Diff | Splinter Review |
This is one of the most recurring preprocessed file in code coverage output. If we could stop using the preprocessor, it would speed up the LCOV rewriting.
|
Assignee | |
Comment 1•7 years ago
|
||
Is this acceptable? It looks green on try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=63eb9ece2c18c1ca74c4e95f7d2d5268956cd7a0.
Attachment #8889884 -
Flags: review?(dteller)
Comment on attachment 8889884 [details] [diff] [review]
Patch
Review of attachment 8889884 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good to me.
Attachment #8889884 -
Flags: review?(dteller) → review+
Pushed by mcastelluccio@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a53dcc2ca0aa
Stop using preprocessor in osfile.jsm. r=Yoric
|
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → mcastelluccio
Status: NEW → ASSIGNED
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
|
||
Updated•1 year ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•