Closed Bug 1384052 Opened 7 years ago Closed 7 years ago

Activity Stream tile labels are too small

Categories

(Firefox :: New Tab Page, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 57
Tracking Status
firefox-esr52 --- unaffected
firefox55 --- unaffected
firefox56 --- disabled
firefox57 + fixed

People

(Reporter: dao, Assigned: Mardak)

References

Details

(Keywords: access)

Attachments

(3 files)

[Tracking Requested - why for this release]: The tile labels significantly undercut OS default font sizes. This is problematic especially for visually impaired users. I have zoomed this page to 133% to see stuff comfortably even though I see my screen unimpaired (I'm only slightly shortsighted).
Summary: Activity stream tile labels are too small → Activity Stream tile labels are too small
Duping to bug 1377317 for now given that design's feedback is the same in bug 1377317 comment 11.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
Bug 1377317 comment 11 says nothing at all about the labels, which I guess means they're supposed to stay as-is. That may be acceptable for top sites we may have high-res icons for, although that's questionable; the labels still exist as a hint besides the icons, and that hint needs to be accessible unless it's considered redundant, in which case we should probably remove the labels rather than making them illegibly small. And then there's the extremely long tail of sites that we won't even have high-res icons for.
Flags: needinfo?(edilee)
Flags: needinfo?(edilee) → needinfo?(abenson)
Separately tracking label size
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
I don't think they're illegibly small .. I believe they're the same size as the font used for the tab labels (11px) on macOS, which isn't an uncommon font size. That being said, we can certainly look into increasing the size as we iterate on the design.
Flags: needinfo?(abenson)
Attached image tab title and site label (deleted) —
(In reply to Aaron Benson from comment #4) > I believe they're the same size as the font used for the tab labels (11px) on macOS Oh indeed they are. Here's a screenshot.
Attached image tab label and AS label on Linux (deleted) —
(In reply to Ed Lee :Mardak from comment #5) > Created attachment 8891832 [details] > tab title and site label > > (In reply to Aaron Benson from comment #4) > > I believe they're the same size as the font used for the tab labels (11px) on macOS > Oh indeed they are. Here's a screenshot. Not at all on Linux. AFAIK it's significantly smaller than the default font size on Windows too.
On Linux, looks like the computed size of tab label is 14.6667px from intl.css top level window font-size: 3mm. https://searchfox.org/mozilla-central/source/toolkit/locales/en-US/chrome/global/intl.css Although using 3mm in activity stream content page results in a computed 11.3333px because of the different font. Looks like it's because tabs use `font: message-box`
Tracked for 57 for now as we still have a few weeks before we enter Beta. As such I'd not consider this a 57 blocker and might drop tracking late Beta if we don't have a fix ready for uplift by then.
(In reply to Ed Lee :Mardak from comment #7) > Looks like it's because tabs use `font: message-box` Can we do the same in activity stream?
Flags: needinfo?(edilee)
Attached image font: message-box (deleted) —
bbell: Here's a screenshot of setting "font: message-box" on Linux. If I do the same on Mac, there's no difference. Looks okay?
Flags: needinfo?(edilee) → needinfo?(bbell)
Blocks: 1387746
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Flags: needinfo?(bbell)
Resolution: --- → FIXED
Assignee: nobody → edilee
No longer blocks: 1387746
Depends on: 1387746
Target Milestone: --- → Firefox 57
Blocks: 1387746
No longer depends on: 1387746
No longer blocks: 1387746
Blocks: 1391336
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: