Closed Bug 1384057 Opened 7 years ago Closed 7 years ago

Stop using preprocessor in nsHelperAppDlg.js

Categories

(Toolkit :: Downloads API, enhancement)

Product:
Toolkit
Component:
Downloads API
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla56
Tracking Flags:
Tracking Status
firefox56 --- fixed

People

(Reporter: marco, Assigned: marco)

References

Details

Attachments

(1 file, 1 obsolete file)

Patch
(deleted), patch
Paolo
: review+
Details | Diff | Splinter Review
The preprocessor is only used to distinguish GTK3 vs GTK2 builds.
Attached patch stop_using_preprocessor_in_nsHelperAppDlg (obsolete) (deleted) — — Splinter Review
Assignee: nobody → mcastelluccio
Status: NEW → ASSIGNED
Attachment #8889887 - Flags: review?(paolo.mozmail)
Attached patch Patch (deleted) — — Splinter Review
Reordered entries in moz.build in alphabetical order to avoid build error.
Attachment #8889887 - Attachment is obsolete: true
Attachment #8889887 - Flags: review?(paolo.mozmail)
Attachment #8890046 - Flags: review?(paolo.mozmail)
Attachment #8890046 - Flags: review?(paolo.mozmail) → review+
Pushed by mcastelluccio@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/68a7ead060bf Stop using preprocessor in nsHelperAppDlg.js. r=paolo
https://hg.mozilla.org/mozilla-central/rev/68a7ead060bf
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: