Closed
Bug 1384068
Opened 7 years ago
Closed 7 years ago
Wrong Change search settings redirection from about:newtab and about:home after preferences v2 reorg
Categories
(Firefox :: Settings UI, defect, P1)
Tracking
()
RESOLVED
DUPLICATE
of bug 1384402
Firefox 56
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | unaffected |
| firefox55 | --- | unaffected |
| firefox56 | --- | fixed |
People
(Reporter: phorea, Assigned: evanxd)
References
Details
(Keywords: regression)
Attachments
(2 files)
about:preferences#general is empty
+++ This bug was initially created as a clone of Bug #1378136 +++
[Note]:
- Does not reproduce when the button is selected from search bar or url bar with one-off
[Affected versions]:
- Nightly 56.0a1 2017-07-24
[Affected platforms]:
- Win 10 64-bit
- Mac OS X 10.12.5
- Ubuntu 14.04 64-bit
[Steps to reproduce]:
1. Open about:newtab and about:home
2. Enter some text in Search field to open dropdown
3. Select "Change Search Settings" button
[Expected result]:
- about:preferences#search page is opened
[Actual result]:
- about:preferences#general page opens and it has no content
[Regression range]:
- Regressed by bug 1365133 (about:preferences reorg v2)
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•7 years ago
|
Attachment #8890131 -
Flags: review?(jaws)
|
|
Assignee | |
Comment 3•7 years ago
|
||
Hi Jared,
Could you help review the patch?
Thank you.
|
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → evan
Status: NEW → ASSIGNED
Flags: qe-verify+
QA Contact: hani.yacoub
|
||
Updated•7 years ago
|
Target Milestone: --- → Firefox 56
| Comment hidden (mozreview-request) |
|
||
Comment 5•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8890131 [details]
Bug 1384068 - Clicking search settings should redirect to about:preferences#search in old and new org since new org move search section into an independent pane.
https://reviewboard.mozilla.org/r/161212/#review166766
Can you please add a test for this? We shouldn't have silently broken it.
Attachment #8890131 -
Flags: review?(jaws) → review-
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 11•7 years ago
|
||
This issue is already fixed by Bug 1384402.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8890131 -
Flags: review?(jaws)
|
|
Assignee | |
Updated•7 years ago
|
Whiteboard: [photon-preference]
|
||
Updated•7 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•