Closed
Bug 1384294
Opened 7 years ago
Closed 7 years ago
label HttpChannelChild::SetIsTrackingResource
Categories
(Core :: Networking: HTTP, enhancement)
Core
Networking: HTTP
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: froydnj, Assigned: schien)
References
Details
(Whiteboard: [necko-active])
Attachments
(1 file)
This runnable comes in fairly high on the list, according to telemetry. Which is depressing!
It's not clear to me what the right thing to do here is. HttpBackgroundChannelChild::RecvNotifyTrackingResource() says that the notification is to be handled "as soon as possible", but then HttpChannelChild::ProcessNotifyTrackingResource allocates and dispatches an event to set a boolean flag? Couldn't we just set the flag straightaway here?
If not, HttpChannelChild::SetEventTarget attempts to associate an event target with `this`, but it's not clear to me that we could retrieve that event target in ProcessNotifyTrackingResource and use that for dispatching. If we can't do that, I don't see a good way to send this event to anything but SystemGroup.
Jason, can you provide some guidance here?
Flags: needinfo?(jduell.mcbugs)
Assignee | ||
Comment 1•7 years ago
|
||
Hmm, maybe I should replace the |GetMainThreadEventTarget| with |GetNeckoTarget|, which is the associated with the corresponding docgroup/tabgroup.
Assignee | ||
Comment 2•7 years ago
|
||
Making |HttpBaseChannel::mIsTrackingResource| atomic and call |SetIsTrackingResource()| directly in HttpChannelChild::ProcessNotifyTrackingResource is also doable. Not sure why I didn't take this solution at the first place while writing the PBg-Http code.
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → schien
Comment 4•7 years ago
|
||
Thanks for working on this, SC.
I thinks we can remove the ni to Jason.
Flags: needinfo?(jduell.mcbugs)
Whiteboard: [necko-active]
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8890239 [details]
Bug 1384294 - replace GetMainThreadEventTarget with GetNeckoTarget in HttpChannelChild.
https://reviewboard.mozilla.org/r/161360/#review167398
Attachment #8890239 -
Flags: review?(honzab.moz) → review+
Pushed by schien@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d42bfe2b2e63
replace GetMainThreadEventTarget with GetNeckoTarget in HttpChannelChild. r=mayhemer
Comment 7•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•