Closed
Bug 1384307
Opened 7 years ago
Closed 7 years ago
WebAuthn PublicKeyCredential object's "id" and "type" fields must be set
Categories
(Core :: DOM: Device Interfaces, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: jcj, Assigned: jcj)
References
(Blocks 1 open bug)
Details
(Whiteboard: [webauthn] [webauthn-interop])
Attachments
(1 file)
The "PublicKeyCredential" WebIDL object's "id", "discovery", and "type" fields are blank in Firefox Nightly.
Both of those fields are inherited from Credential Management's WebIDL "Credential" type. [1]
"id" should be set to the base64url encoding of the data in "rawId".
"type" should be the literal "public-key"
"discovery" should be the literal "remote", but as an "internal slot" it doesn't appear in the WebIDL, nor have a Getter. So that might be a follow-up to resolve.
[1] https://www.w3.org/TR/webauthn/#publickeycredential
Assignee | ||
Updated•7 years ago
|
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8890115 [details]
Bug 1384307 - Set WebAuthn PublicKeyCredential's "id" and "type" fields
https://reviewboard.mozilla.org/r/161200/#review166546
Cool - lgtm.
::: dom/webauthn/tests/test_webauthn_loopback.html:54
(Diff revision 1)
> - attestationObject: CBOR object
> - clientDataJSON: serialized JSON
> - clientExtensionResults: (not yet supported)
> */
>
> + is(aCredInfo.type, "public-key", "Credential type must be public-key")
nit: to me it makes sense to check these in the same order as the comment, but no big deal
Attachment #8890115 -
Flags: review?(dkeeler) → review+
Assignee | ||
Comment 3•7 years ago
|
||
Thanks for the review, David!
Marking checkin-needed.
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/42013738df2a
Set WebAuthn PublicKeyCredential's "id" and "type" fields r=keeler
Keywords: checkin-needed
Comment 5•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•