Regression of bug 1280898: https://hg.mozilla.org/comm-central/diff/fd02e757b142/calendar/import-export/calOutlookCSVImportExport.js The variable 'locale' has been moved to a tighter scope, but is still used afterwards. Also note that the "nl" locale has been used for the Outlook 2000 format (last loop iteration, without breaking), seems like a bad default to me. STR: 0. Thunderbird 52.2.1 1. Open the error console 2. Import a supported CSV file (manually creating it if your version and locale from Outlook is not supported) Expected: The import succeeds, no messages in the error console. Actual: The import does not work, error console: [Exception... "[JavaScript Error: "locale is not defined" {file: "resource://calendar/modules/calUtils.jsm -> file:///C:/Users/xxxxx/AppData/Roaming/Thunderbird/Profiles/aw03o5my.default/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/calendar-js/calOutlookCSVImportExport.js" line: 245}]'[JavaScript Error: "locale is not defined" {file: "resource://calendar/modules/calUtils.jsm -> file:///C:/Users/xxxxx/AppData/Roaming/Thunderbird/Profiles/aw03o5my.default/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/calendar-js/calOutlookCSVImportExport.js" line: 245}]' when calling method: [calIImporter::importFromStream]" nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)" location: "JS frame :: chrome://calendar/content/import-export.js :: loadEventsFromFile :: line 85" data: yes] (Taken from a German Thunderbird forum, see attached url for the original post in German)

Confirming by code inspection. The issue still exists in trunk.

This patch takes care and removes an unneccessary check for a time parameter as there exists code for handling that specific case later on.

You have some strange characters in the patch, "hg out" gives: summary: ´╗┐Bug 1384587 - Outlook CSV import is broken;r=mschroeder

Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/efffc843dbfa Outlook CSV import is broken. r=mschroeder

Calendar 5.7: https://hg.mozilla.org/releases/comm-beta/rev/13c8920ec9a856084e0a922aedf87698eb8472f6 Calendar 5.4.3: https://hg.mozilla.org/releases/comm-esr52/rev/d409fb9df1a1bafb841e906e30a3c51b8047781c