Closed Bug 1384906 Opened 7 years ago Closed 7 years ago

TEST-START and TEST-END log lines are missing newline

Categories

(Remote Protocol :: Marionette, enhancement)

Version 3
enhancement
Not set
normal

Tracking

(firefox56 fixed)

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: ato, Assigned: ato)

Details

Attachments

(1 file)

Example from a recent log: > TEST-START: test_window_maximize.py TestWindowMaximize.test_maximize1501116863955 Marionette TRACE 221 <- [1,5,null,{"value":null}] The TEST-START and TEST-END log entries are missing a newline character.
Assignee: nobody → ato
Status: NEW → ASSIGNED
Comment on attachment 8890827 [details] Bug 1384906 - Use newline in TEST-START and TEST-END log entries; https://reviewboard.mozilla.org/r/162050/#review167390
Attachment #8890827 - Flags: review?(dburns) → review+
hg error in cmd: hg pull gecko -r b650094c6e0ff670a65538e839499bac5c283191: pulling from https://reviewboard-hg.mozilla.org/gecko abort: HTTP Error 500: Internal Server Error
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/33aa6e07a9d6 Use newline in TEST-START and TEST-END log entries; r=automatedtester
Backed out for failing marionette with "unterminated string litera" @testcases.py, line 316: https://hg.mozilla.org/integration/autoland/rev/6025770ffa49e46b4d80b42f430530ebfa612a7a A push with failing marionette runs: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=b8c498fb8223517460c4124cb3d822718cc6e38a&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable&filter-resultStatus=success&filter-searchStr=marionette Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=118584224&repo=autoland [task 2017-07-27T17:44:00.165558Z] 17:44:00 INFO - TEST-UNEXPECTED-ERROR | test_marionette.py TestMarionette.test_correct_test_name | JavascriptException: SyntaxError: unterminated string literal [task 2017-07-27T17:44:00.166036Z] 17:44:00 INFO - stacktrace: [task 2017-07-27T17:44:00.166206Z] 17:44:00 INFO - execute_script @testcases.py, line 316 [task 2017-07-27T17:44:00.166405Z] 17:44:00 INFO - inline javascript, line 0 [task 2017-07-27T17:44:00.166747Z] 17:44:00 INFO - src: "dump('TEST-START: test_marionette.py TestMarionette.test_correct_test_name" [task 2017-07-27T17:44:00.166911Z] 17:44:00 INFO - Stack: [task 2017-07-27T17:44:00.167291Z] 17:44:00 INFO - Traceback (most recent call last): [task 2017-07-27T17:44:00.167438Z] 17:44:00 INFO - File "/home/worker/workspace/build/venv/local/lib/python2.7/site-packages/marionette_harness/marionette_test/testcases.py", line 137, in run [task 2017-07-27T17:44:00.167794Z] 17:44:00 INFO - self.setUp() [task 2017-07-27T17:44:00.167977Z] 17:44:00 INFO - File "/home/worker/workspace/build/venv/local/lib/python2.7/site-packages/marionette_harness/marionette_test/testcases.py", line 316, in setUp [task 2017-07-27T17:44:00.168079Z] 17:44:00 INFO - sandbox="simpletest") [task 2017-07-27T17:44:00.168269Z] 17:44:00 INFO - File "/home/worker/workspace/build/venv/local/lib/python2.7/site-packages/marionette_driver/marionette.py", line 1749, in execute_script [task 2017-07-27T17:44:00.168796Z] 17:44:00 INFO - rv = self._send_message("executeScript", body, key="value") [task 2017-07-27T17:44:00.168986Z] 17:44:00 INFO - File "/home/worker/workspace/build/venv/local/lib/python2.7/site-packages/marionette_driver/decorators.py", line 23, in _ [task 2017-07-27T17:44:00.169202Z] 17:44:00 INFO - return func(*args, **kwargs) [task 2017-07-27T17:44:00.169838Z] 17:44:00 INFO - File "/home/worker/workspace/build/venv/local/lib/python2.7/site-packages/marionette_driver/marionette.py", line 739, in _send_message [task 2017-07-27T17:44:00.170687Z] 17:44:00 INFO - self._handle_error(err) [task 2017-07-27T17:44:00.171359Z] 17:44:00 INFO - File "/home/worker/workspace/build/venv/local/lib/python2.7/site-packages/marionette_driver/marionette.py", line 772, in _handle_error [task 2017-07-27T17:44:00.172108Z] 17:44:00 INFO - raise errors.lookup(error)(message, stacktrace=stacktrace)
Flags: needinfo?(ato)
Missing a r"\n" to make it a literal string.
Flags: needinfo?(ato)
Pushed by atolfsen@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/03d094e1e0db Use newline in TEST-START and TEST-END log entries; r=automatedtester
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: