Closed
Bug 1384936
Opened 7 years ago
Closed 7 years ago
Stop using preprocessor in services/sync/modules/constant.js
Categories
(Firefox :: Sync, enhancement)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
Firefox 56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: marco, Assigned: marco)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
rnewman
:
review+
|
Details | Diff | Splinter Review |
This is one of the few remaining script using the preprocessor.
|
Assignee | |
Comment 1•7 years ago
|
||
Assignee: nobody → mcastelluccio
Status: NEW → ASSIGNED
Attachment #8890864 -
Flags: review?(markh)
Attachment #8890864 -
Flags: review?(jlorenzo)
Comment on attachment 8890864 [details] [diff] [review]
Patch
I'm sorry. I don't think I'm suited to review this patch.
Attachment #8890864 -
Flags: review?(jlorenzo)
|
|
Assignee | |
Comment 3•7 years ago
|
||
Comment on attachment 8890864 [details] [diff] [review]
Patch
Rail or Nick, can you review?
Attachment #8890864 -
Flags: review?(rail)
Attachment #8890864 -
Flags: review?(nthomas)
|
||
Comment 4•7 years ago
|
||
Comment on attachment 8890864 [details] [diff] [review]
Patch
Sorry, I am not familiar with this component enough. :/ The merge day part lgtm.
Attachment #8890864 -
Flags: review?(rail)
|
||
Updated•7 years ago
|
Attachment #8890864 -
Flags: review?(markh) → review+
|
|
Assignee | |
Comment 5•7 years ago
|
||
(In reply to Rail Aliiev [:rail] ⌚️ET - PTO in August from comment #4)
> Comment on attachment 8890864 [details] [diff] [review]
> Patch
>
> Sorry, I am not familiar with this component enough. :/ The merge day part
> lgtm.
Thanks, that's the part I wanted a review from either you or nthomas :)
Try is green: https://treeherder.mozilla.org/#/jobs?repo=try&revision=cf844bbca1a3cc7b4f3d66eee77c3dd9af70806e.
Pushed by mcastelluccio@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0d580486af34
Remove weave_version definition and directly replace the constant in modules/constants.js in the gecko migration script, to avoid the need for the preprocessor in modules/constants.js. r=rnewman,rail
|
||
Updated•7 years ago
|
Attachment #8890864 -
Flags: review?(nthomas)
|
||
Comment 7•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
|
||
Updated•5 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•