Closed
Bug 1385191
Opened 7 years ago
Closed 7 years ago
Prefer email address from the FxA profile over that from the account
Categories
(Firefox :: Firefox Accounts, enhancement, P1)
Firefox
Firefox Accounts
Tracking
()
RESOLVED
FIXED
Firefox 56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: markh, Assigned: markh)
References
Details
Attachments
(1 file)
In bug 1383663 we want to handle the fact a user's email address might change. Doing that correctly is not completely trivial, but a small step we could take in the meantime is to prefer the email address from the profile over what we have stored for the account. It will mean that a user may briefly see the email address flip from the old to the new, but this seems better than forever showing old.
|
Assignee | |
Comment 1•7 years ago
|
||
Ed, I'm about to put a patch up - if you think it's OK, please go ahead and land it so it makes the merge (but no big deal if you have concerns - it can wait)
Assignee: nobody → markh
| Comment hidden (mozreview-request) |
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8891202 [details]
Bug 1385191 - Prefer email address from the FxA profile over that from the account.
https://reviewboard.mozilla.org/r/162424/#review167796
This looks fine to me, thanks.
Attachment #8891202 -
Flags: review?(eoger) → review+
Pushed by eoger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e9bb73e285c4
Prefer email address from the FxA profile over that from the account. r=eoger
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
|
||
Updated•7 years ago
|
Product: Core → Firefox
|
||
Updated•7 years ago
|
Target Milestone: mozilla56 → Firefox 56
You need to log in
before you can comment on or make changes to this bug.
Description
•