1) Click on, say, Environment Data - shows all environment data 2) Click on Build - shows build, environment data 3) Click on Environment Data Expected: shows all environment data Actual: still shows just the build environment data I think the other subsections' data sections need to toggle back to visible when selecting the section in the sidebar.

Comment on attachment 8895137 [details] Bug 1385270 - Fix about:telemetry subsection display https://reviewboard.mozilla.org/r/166262/#review172308 I tested this locally with the steps from the comment 0 and the behavior wasn't fixed.

Comment on attachment 8895137 [details] Bug 1385270 - Fix about:telemetry subsection display https://reviewboard.mozilla.org/r/166262/#review173558 This fixes the problem for me, but i have some small issues below. Also, this needs rebasing - or does it depend on some other patch? ::: toolkit/content/aboutTelemetry.js:1896 (Diff revision 2) > */ > function show(selected) { > let current_button = document.querySelector(".category.selected"); > current_button.classList.remove("selected"); > + if (current_button.classList.contains("has-subsection")) { > + Array.from(current_button.children).forEach((subsection) => Why not just use a normal loop? ``` for (let subsection of current_button.children) { ... ``` ::: toolkit/content/aboutTelemetry.js:1897 (Diff revision 2) > function show(selected) { > let current_button = document.querySelector(".category.selected"); > current_button.classList.remove("selected"); > + if (current_button.classList.contains("has-subsection")) { > + Array.from(current_button.children).forEach((subsection) => > + subsection.classList.remove("selected") Missing semicolon at the end of this line. ::: toolkit/content/aboutTelemetry.js:1909 (Diff revision 2) > let selectedValue = selected.getAttribute("value"); > let current_section = document.querySelector("section.active"); > let selected_section = document.getElementById(selectedValue); > + let subsections = current_section.querySelectorAll(".sub-section"); > + if (subsections) { > + subsections.forEach((subsection) => subsection.hidden = false); Same here, why not a normal loop?

Comment on attachment 8895137 [details] Bug 1385270 - Fix about:telemetry subsection display https://reviewboard.mozilla.org/r/166262/#review173598 ::: toolkit/content/aboutTelemetry.js:1896 (Diff revision 2) > */ > function show(selected) { > let current_button = document.querySelector(".category.selected"); > current_button.classList.remove("selected"); > + if (current_button.classList.contains("has-subsection")) { > + Array.from(current_button.children).forEach((subsection) => I had the habit to use this way. I'm changing it back to simple for loop :). ::: toolkit/content/aboutTelemetry.js:1909 (Diff revision 2) > let selectedValue = selected.getAttribute("value"); > let current_section = document.querySelector("section.active"); > let selected_section = document.getElementById(selectedValue); > + let subsections = current_section.querySelectorAll(".sub-section"); > + if (subsections) { > + subsections.forEach((subsection) => subsection.hidden = false); It's more concise here to use forEach. I think we can keep it ?

(In reply to flyingrub from comment #5) > ::: toolkit/content/aboutTelemetry.js:1909 > (Diff revision 2) > > let selectedValue = selected.getAttribute("value"); > > let current_section = document.querySelector("section.active"); > > let selected_section = document.getElementById(selectedValue); > > + let subsections = current_section.querySelectorAll(".sub-section"); > > + if (subsections) { > > + subsections.forEach((subsection) => subsection.hidden = false); > > It's more concise here to use forEach. I think we can keep it ? Readability and standard control structures trump saving two lines for me here.

Comment on attachment 8895137 [details] Bug 1385270 - Fix about:telemetry subsection display https://reviewboard.mozilla.org/r/166262/#review173974

Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/47cf76ef4d3d Fix about:telemetry subsection display r=gfritzsche