Closed
Bug 1385337
Opened 7 years ago
Closed 7 years ago
Write MDN page describing source map failures and how to fix them
Categories
(Developer Documentation Graveyard :: Developer Tools, enhancement, P2)
Developer Documentation Graveyard
Developer Tools
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: tromey, Assigned: tromey)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
In bug 1345533, I'm going to change the devtools to report source map errors
to the web console. In bug 1385032, :bgrins made the excellent suggestion to
have an MDN page describing the different errors and what might be done to
fix them.
I think it would make sense to write this page after landing bug 1345533,
so we can make screen shots. Meanwhile, I'm filing the bug to be sure it is
on the source-map to-do list.
Assignee | ||
Comment 1•7 years ago
|
||
Specifically see the suggestions at the end of https://bugzilla.mozilla.org/show_bug.cgi?id=1385032#c2
This bug may also require landing a change to errordocs.js in devtools.
Updated•7 years ago
|
Assignee | ||
Updated•7 years ago
|
Priority: -- → P2
Assignee | ||
Comment 2•7 years ago
|
||
I've been talking with Chris Mills and Sole about this.
Chris is going to make a stub page and I will fill it in.
Assignee: nobody → ttromey
Assignee | ||
Comment 3•7 years ago
|
||
I've got a URL now, so I wrote the patch.
Unsure if we should land this before I write the text.
Comment hidden (mozreview-request) |
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8908774 [details]
Bug 1385337 - add MDN learn more link to source map errors;
https://reviewboard.mozilla.org/r/180386/#review186058
Looks good to me with the selector updated. I think it'd be OK to land without the text on the page as long as it's coming relatively soon.
::: devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_sourcemap_nosource.js:55
(Diff revision 1)
> yield toolbox.selectTool("webconsole");
>
> const node = yield waitFor(() => findMessage(hud, "original source"));
> ok(node, "source map error is displayed in web console");
> +
> + ok(!!node.querySelector(".message-body"), "source map error has learn more link");
This selector could be `.learn-more-link` instead. For example, something like this:
is(node.querySelectorAll(".learn-more-link").length, 1, "source map error has learn more link");
Attachment #8908774 -
Flags: review?(bgrinstead) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Comment 7•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8908774 [details]
Bug 1385337 - add MDN learn more link to source map errors;
https://reviewboard.mozilla.org/r/180386/#review186058
> This selector could be `.learn-more-link` instead. For example, something like this:
>
> is(node.querySelectorAll(".learn-more-link").length, 1, "source map error has learn more link");
Oops, sorry about that.
Pushed by ttromey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5430d402cfd5
add MDN learn more link to source map errors; r=bgrins
Comment 9•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•