Open Bug 1385520 Opened 7 years ago Updated 2 years ago

[Photon] Color the tab strip when the the title bar is enabled

Categories

(Firefox :: Theme, enhancement, P5)

enhancement

Tracking

()

People

(Reporter: nhnt11, Unassigned, NeedInfo)

Details

(Whiteboard: [reserve-photon-visual][p4])

No description provided.
Whiteboard: [photon-visual]t → [photon-visual]
Whiteboard: [photon-visual] → [photon-visual] [triage]
During triage we discussed this and some points came up: - Currently we are "extending" the titlebar gradient into the tab strip, so that the whole thing looks like one homogeneous titlebar (at least on macOS) - Maybe this will look fine with Photon tab style tabs? (I think it will look bad) - Should we color only the tab strip? - We've seen that sometimes the titlebar is transparent, for example allowing the background to show through for compact themes like Space Fantasy. Can we color the titlebar+tabstrip instead of just the tab strip? So, I started investigating this and ran into an old friend: the bug where setting the drawInTitlebar pref behaves differently when toggled from about:config vs from Customize Mode. Here are some findings on macOS: - The styling of the titlebar text seems to be out of our control as far as I can tell, so we can't use a dark background for it - the text will be invisible. - When the titlebar is toggled from Customize Mode (which is the "common" case) the styling of the background of the titlebar is also out of our control. - When the titlebar is toggled from about:config, the styling of the background of the titlebar IS in our control, and seems to be transparent at the moment, but it can be changed. -moz-window-titlebar works. Considering we seem to be stuck with a dark text color, seems like we can't make the titlebar "vibrant" to go with the tabstrip. So I think the final question to be answered is (in the context of macOS), since the titlebar background has to be light to accommodate the dark text, which is uglier? a) Photon style tabs on the macOS titlebar gradient background (I need to check what it looks like with the titlebar enabled on other platforms) b) A dark tabstrip with the usual macOS gradient titlebar above it.
Flags: qe-verify+
Priority: -- → P2
QA Contact: brindusa.tot
Whiteboard: [photon-visual] [triage] → [photon-visual]
How about light vibrancy on both the titlebar and the tabs ?
I think we're good with the current look. When I last checked out Photon style tabs on MacOS with titlebar turned on they were broken because of other issues. Now, on Nightly, IMO, they look completely fine. Maybe we should separately track the issue of changing the titlebar text (since it's also needed for dark themes?). Stephen, can you enable the titlebar on your Nightly and give us an opinion on what we should do, given the constraints outlined in comment 1?
Flags: needinfo?(shorlander)
Priority: P2 → P3
Whiteboard: [photon-visual] → [reserve-photon-visual]
Whiteboard: [reserve-photon-visual] → [reserve-photon-visual][p4]
Priority: P3 → P4
Priority: P4 → P5
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.