PROCESS is faster than INCLUDE; where we don't need the aliasing behaviour of INCLUDE, we should use PROCESS. This is a search-and-replace job, basically - there's only about one place we need INCLUDE - that's in dependency-tree.html.tmpl. Gerv

We need the patch on bug 135707 first, because it touches all the same lines of the templates. Gerv

All INCLUDEs to PROCESS where appropriate. Gerv

This patch is not affected by the files I forgot, which all used PROCESS anyway. It's ready for review (and blocking any further work on the templates :-( ). Gerv

Taking. Gerv

Comment on attachment 80103 [details] [diff] [review] Patch v.1 I can't actually apply this to test (because you're using the new templaet stuff), but its just changing header and footers except for one case. r=bbaetz

This is the essence of the patch (i.e. all bug header/footer changes): ggrep -E '^[\+-]' include2process.patch | grep -v global/header.html.tmpl | grep -v global/footer.html.tmpl | grep -v '+++ template/en/default' | grep -v '\-\-\- template/en/default' 1. In template/en/default/account/prefs/prefs.html.tmpl , looks ok: - [% INCLUDE "account/prefs/${current_tab.name}.html.tmpl" IF current_tab.name.defined %] + [% PROCESS "account/prefs/${current_tab.name}.html.tmpl" IF current_tab.name.defined %] 2. In template/en/default/bug/activity/show.html.tmpl , looks ok: -[% INCLUDE bug/activity/table.html.tmpl %] +[% PROCESS bug/activity/table.html.tmpl %] 3. In template/en/default/bug/create/created.html.tmpl , looks ok: -[% INCLUDE bug/navigate.html.tmpl %] +[% PROCESS bug/navigate.html.tmpl %] 4. In template/en/default/bug/edit.html.tmpl , looks ok: - [% INCLUDE attachment/list.html.tmpl + [% PROCESS attachment/list.html.tmpl 5. In template/en/default/bug/show-multiple.html.tmpl : This should probably fixed to read global/footer.html.tmpl :-) If you fix this, you have r=afranke. Testing this patch now. IMO there's no need for a new patch, so fix this and check it in. -[% INCLUDE global/footer %] +[% PROCESS global/footer %]

Comment on attachment 80103 [details] [diff] [review] Patch v.1 Or, better yet, fix the footer --> footer.html.tmpl in a separate checkin after this one. You have an implicit r=afranke x2 on that one.

All fixed. Excellent :-) Gerv