User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.115 Safari/537.36 Steps to reproduce: I am using the following code for test: browser.webRequest.onBeforeSendHeaders.addListener( event => { console.log( 'onBeforeSendHeaders' ); console.log( event ); return; }, { 'urls': [ '<all_urls>' ] }, [ 'blocking', 'requestHeaders' ] ); This code in Embedded WebExtension, not pure webextension Actual results: console.log is not outputted in FF dev edition. In current normal Firefox all is working Expected results: It must work!

55.0b13 64 bit

My manifest permissions: "permissions": [ "background", "proxy", "storage", "webRequest", "webRequestBlocking", "<all_urls>" ],

Minimal code for testing: manifest.json { "manifest_version": 2, "name": "dev", "short_name": "dev", "version": "3.16.8", "description": "description", "background": { "scripts": [ "background.js" ] }, "icons": { "64": "app_icon64.png" }, "permissions": [ "background", "proxy", "storage", "webRequest", "webRequestBlocking", "<all_urls>" ], "optional_permissions": [ "management", "chrome://favicon/" ], "content_security_policy": "script-src 'self' https://ssl.google-analytics.com; object-src 'self'" }

background.js console.log( 'background start' ); browser.webRequest.onBeforeSendHeaders.addListener( event => { console.log( 'onBeforeSendHeaders' ); console.log( event ); return; }, { 'urls': [ '<all_urls>' ] }, [ 'blocking', 'requestHeaders' ] ); console.log( 'background test 1' );

By chat conservations: in just FF beta there is no bug, in FF dev edition there is bug

*conversations

Personally tested in pure Firefox Beta - this test (above) does not work for me

The issue is with your manifest, firefox doesn't support the "chrome://favicon/" permission, so your extension doesn't even load. Unfortunately, the error is invisible unless you are using the current Nightly (which is generally suggested while developing).

What it's working in FF54?

*Why

Not sure, we probably started being strict about permissions in 55.

Sound like bug 1373293 which was fixed in 56.

But that says it got uplifted to 55, which doesn't match my testing. Reopening since it seems the fix for bug 1373293 missed optional_permissions, and this is breaking webrequests as is.

Comment on attachment 8893597 [details] Bug 1385864 - Drop invalid optional_permissions from manifests https://reviewboard.mozilla.org/r/164684/#review170098

Pushed by tomica@gmail.com: https://hg.mozilla.org/integration/autoland/rev/ca0419d7845f Drop invalid optional_permissions from manifests r=kmag

Comment on attachment 8893597 [details] Bug 1385864 - Drop invalid optional_permissions from manifests Approval Request Comment [Feature/Bug causing the regression]: Bug 1322235 [User impact if declined]: This prevents certain extensions from being installed. [Is this code covered by automated tests?]: Yes. [Has the fix been verified in Nightly?]: No. [Needs manual test from QE? If yes, steps to reproduce]: No, manually tested from local build. [List of other uplifts needed for the feature/fix]: None. [Is the change risky?]: Low-risk. [Why is the change risky/not risky?]: it's very simple, just marks unknown strings to be dropped from manifest. [String changes made/needed]: None.

Comment on attachment 8893597 [details] Bug 1385864 - Drop invalid optional_permissions from manifests Looks like we need this for webextensions to work - let's uplift for 56 beta 1.

(In reply to Tomislav Jovanovic :zombie from comment #18) > [Is this code covered by automated tests?]: Yes. > [Has the fix been verified in Nightly?]: No. > [Needs manual test from QE? If yes, steps to reproduce]: No, manually tested > from local build. Setting qe-verify- based on Tomislav's assessment on manual testing needs and the fact that this fix has automated coverage.

Related to bug 1315616?