Closed
Bug 1385884
Opened 7 years ago
Closed 7 years ago
Stylo: With ABP installed (and huge filter list) and Stylo enabled, page continuously uses 100% CPU and does not finish loading
Categories
(Core :: CSS Parsing and Computation, defect, P1)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: mayankleoboy1, Assigned: bradwerth)
References
()
Details
Attachments
(2 files)
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0
Build ID: 20170730100307
Steps to reproduce:
1. Enable stylo
2. install ABP
Go to http://www.digitaljournal.com/tech-and-science/technology/a-step-closer-to-skynet-ai-invents-a-language-humans-can-t-read/article/498142
Actual results:
Site keeps on loading, CPU usage is 100%
If you switch to another tab and then switch to this one, you will see a spinner
Expected results:
Not so
Reporter | ||
Updated•7 years ago
|
Flags: needinfo?(bobbyholley)
Reporter | ||
Updated•7 years ago
|
Updated•7 years ago
|
Blocks: stylo-site-issues
Flags: needinfo?(bobbyholley)
Reporter | ||
Comment 2•7 years ago
|
||
I am on Win10x64, with OOP-Webextensions enabled by default. That might be a factor in reproducing.
Also, you might try using the filter list from here: https://bugzilla.mozilla.org/attachment.cgi?id=8890882 if the default filter list in ABP does not reproduce.
Reporter | ||
Comment 3•7 years ago
|
||
OK, I confirmed this. So basically with Stylo+ABP, Nightly has two behaviors for this bug:
1. If the filter list is default that comes preloaded with ABP, then browser shows same behaviour as bug 1384945
2. If filter list is huge, as https://bugzilla.mozilla.org/attachment.cgi?id=8890882 this, then the browser shows the behavior described in comment 0
ni? so that you can see my findings.
Flags: needinfo?(bwerth)
Reporter | ||
Updated•7 years ago
|
Summary: Stylo: With ABP installed and Stylo enabled, page continuously uses 100% CPU and does not finish loading → Stylo: With ABP installed (and huge filter list) and Stylo enabled, page continuously uses 100% CPU and does not finish loading
Reporter | ||
Comment 4•7 years ago
|
||
My filter list. Using this in ABP will reproduce behavior of comment 0
Comment 5•7 years ago
|
||
(In reply to Mayank Bansal from comment #0)
> 1. Enable stylo
> 2. install ABP
I'm assuming you have installed the stable or dev version (both legacy) from https://addons.mozilla.org/firefox/addon/adblock-plus/ ?
(I am just a Nightly user)
Today is the birth of Firefox 57 and it won't support Legacy extensions, so I would request the Stylo people to only focus on webextension (or system addon) performance.
https://downloads.adblockplus.org/devbuilds/adblockplusfirefox/
If you've tested the webextension: Do you see the same behavior there? (If you haven't, could you please? :D)
(If you are using ABP personally, I would like to suggest you uBlock Origin https://github.com/gorhill/uBlock/releases)
Comment 6•7 years ago
|
||
I can't reproduce either this nor bug 1384945 with ABP's webext on Debian testing. CPU is the same, RAM not that higher. Everything is smooth. Maybe this is architecture- or OS-specific?
Updated•7 years ago
|
Priority: -- → P1
Updated•7 years ago
|
No longer blocks: stylo-site-issues
Assignee | ||
Comment 7•7 years ago
|
||
(In reply to Mayank Bansal from comment #4)
> Created attachment 8892458 [details]
> MyFilters.ini
>
> My filter list. Using this in ABP will reproduce behavior of comment 0
Thank you for this. I can't figure out how to import your .ini file. I attempted to Add filter subscription -> Add a different subscription... and then put the file:// URL to the .ini file, but that was rejected with "Filter list location is neither a valid URL nor a valid file name." How do I import it?
Flags: needinfo?(mayankleoboy1)
Reporter | ||
Comment 8•7 years ago
|
||
I cant reproduce this bug anymore. I dont know if things changed in Stylo or ABP.
Please close this bug (and its dependent bug) appropriately.
Flags: needinfo?(mayankleoboy1)
Comment 9•7 years ago
|
||
(In reply to Mayank Bansal from comment #8)
> I cant reproduce this bug anymore. I dont know if things changed in Stylo
> or ABP.
> Please close this bug (and its dependent bug) appropriately.
Thanks!
Status: UNCONFIRMED → RESOLVED
Closed: 7 years ago
Resolution: --- → WORKSFORME
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(bwerth)
You need to log in
before you can comment on or make changes to this bug.
Description
•