Closed
Bug 1385902
Opened 7 years ago
Closed 7 years ago
"Find in Preferences" placeholder is truncated in French
Categories
(Firefox :: Settings UI, defect, P1)
Tracking
()
VERIFIED
FIXED
Firefox 57
People
(Reporter: tchevalier, Assigned: rickychien)
References
(Blocks 1 open bug)
Details
(Keywords: nightly-community, Whiteboard: [photon-preference])
Attachments
(3 files)
(deleted),
image/png
|
Details | |
(deleted),
text/x-review-board-request
|
mconley
:
review+
lizzard
:
approval-mozilla-beta+
|
Details |
(deleted),
application/zip
|
Details |
On macOS and Linux, the placeholder text "Find in Preferences" is truncated in French (see screenshot), and we can’t easily shorter the translation.
Other locales may be affected, but it seems French is the longest for this string: https://transvision.mozfr.org/string/?entity=browser/chrome/browser/preferences/preferences.properties:searchInput.labelUnix&repo=central
We’re using a different, shorter string on Windows (Preferences vs. Options), so Windows builds are not affected.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → rchien
Status: NEW → ASSIGNED
Flags: qe-verify+
Priority: -- → P1
Whiteboard: [photon-preference][triage]
Comment 1•7 years ago
|
||
From visual perspective, I suggest to extend the width of the search field to 240px in this case, so we can show the whole string, let me know if any questions!
Assignee | ||
Comment 2•7 years ago
|
||
Per discussion with Helen, we finally decided to extend the width of search field to 230px but set display: none for the .textbox-search-icons to reduce extra space.
Comment hidden (mozreview-request) |
Updated•7 years ago
|
QA Contact: hani.yacoub
Whiteboard: [photon-preference][triage] → [photon-preference]
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8892303 [details]
Bug 1385902 - Extend the width of preferences search field
https://reviewboard.mozilla.org/r/163250/#review168980
Thanks!
Attachment #8892303 -
Flags: review?(mconley) → review+
Pushed by rchien@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9432c692aae0
Extend the width of preferences search field r=mconley
Comment 6•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Reporter | ||
Updated•7 years ago
|
The issue is still reproducible on Firefox Nightly 57.0a1 on Windows 10 x 64, Mac OS X 10.12 (ID 20170808114032) and Ubuntu 16.04 x64(ID 20170809043657). New screenshots attached.
Comment 8•7 years ago
|
||
This one is fixed (on 56). See bug 1388348 for Nightly.
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
Resolution: --- → FIXED
Comment 9•7 years ago
|
||
(In reply to Francesco Lodolo [:flod] from comment #8)
> This one is fixed (on 56). See bug 1388348 for Nightly.
Ugh, this landed in central after merge day. It needs to be uplifted to beta, since it only affects 56.
Comment 10•7 years ago
|
||
Comment on attachment 8892303 [details]
Bug 1385902 - Extend the width of preferences search field
Approval Request Comment
[Feature/Bug causing the regression]: -
[User impact if declined]: search field in Preferences is cut in some localized builds (e.g. French)
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: it was verified on Nightly before the visual refresh.
[Needs manual test from QE? If yes, steps to reproduce]: -
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: only setting a larger width on the search field.
[String changes made/needed]: none
Attachment #8892303 -
Flags: approval-mozilla-beta?
Updated•7 years ago
|
status-firefox56:
--- → affected
Comment on attachment 8892303 [details]
Bug 1385902 - Extend the width of preferences search field
Search field width fix for l10n. OK for beta 2.
Attachment #8892303 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 12•7 years ago
|
||
bugherder uplift |
Comment 13•7 years ago
|
||
Based on https://bugzilla.mozilla.org/show_bug.cgi?id=1388348#c35, I'll mark this as Verified as fixed on Firefox Nightly 57.0a1 on Windows 10 x 64, Mac OS X 10.12 and a new bug is logged for Ubuntu bug 1392601.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•