From Bugzilla Helper: User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9.9+) Gecko/20020404 Netscape6/6.2.1+ BuildID: 2002041205 Deleting entries (cards) from the Address Book is broken. You can select an entry and then delete it, but it's as if the Delete isn't recognized. There is no error or anything, but the selected entry is not deleted. It remains in the address book and is still active. Reproducible: Always Steps to Reproduce: 1.Go into Address Book, highlight a name you wish to delete. 2.Hit Delete button (or Edit|Delete Card). Actual Results: Nothing happens. The selected entry is not deleted and remains active. Expected Results: The highlighted entry should be removed from the Address Book after it is deleted. This is different issue than Bugzilla #122320 reported by nbaca - that bug is specific to MacOSX. At the time that bug was opened, Mac9.x was working correctly, but now it's broken.

I'm seeing this too, RC1, MacOS9.1

Set QA contact to Nbaca.

I can also reproduce the problem with Mozilla 1.0.0 under Mac OS 9.1.

*** Bug 138334 has been marked as a duplicate of this bug. ***

adding putterman as CC, assigning to sspitzer per puttermans request

confirming.

reassigning to srilatha. Srilatha, can you take a look at this?

I see this problem in today's branch build but I cannot reproduce it in today's branch debug build. Investigating

I can reproduce the problem with a recent debug build under MacOS X. Here is the console output when I press the delete button: •••WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(rv)) failed, file nsAbView.cpp, line 1112 WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(rv)) failed, file nsAbView.cpp, line 1112 ************************************************************ * Call to xpconnect wrapped JSObject produced this error: * [Exception... "Component returned failure code: 0xbfffb1a0 [nsIAbView.deleteSelectedCards]" nsresult: "0xbfffb1a0 (<unknown>)" location: "JS frame :: chrome://messenger/content/addressbook/abCommon.js :: AbDelete :: line 285" data: no] ************************************************************ An error occurred executing the button_delete command

a MacOS 9 debug build from 04/18 works fine for me but I have been told that this problem still exist with release build. Maybe we are using an uninialized variable?

Mac OS9 debug and optmized builds work fine for me but with the build from sweetlou on OS9 I get the same js error. After talking to Jean-Francois reassigning the bug.

*** Bug 140017 has been marked as a duplicate of this bug. ***

in nsAbMDBDirectory::DeleteCards, rv is not initialized in the case mIsQueryURI is null and mDatabase is already initialized. Therefore has we test rv, the function can fail randomly...

Comment on attachment 80980 [details] [diff] [review] Proposed fix, v1 r=srilatha

Comment on attachment 80980 [details] [diff] [review] Proposed fix, v1 sr=bienvenu

thanks for fixing this, JF. I think this was reason why http://bugzilla.mozilla.org/show_bug.cgi?id=117452 was reopened. when you fix this, I think we can mark #117452 fixed.

see bug #122320 as well. this fix might fix that as well. (it's probably a dup)

*** Bug 122320 has been marked as a duplicate of this bug. ***

Fix checked in the trunk

this would be great for the branch, adding adt1.0.0

adt1.0.0+ (on ADT's behalf) approval for checkin to the 1.0 branch. Pls check this into the 1.0 branch as soon as you receive a= from Drivers, then add keyword fixed1.0.0.

Comment on attachment 80980 [details] [diff] [review] Proposed fix, v1 a=asa (on behalf of drivers) for checkin to the 1.0 branch

fix checked in the branch too.

This has been tested on both 9.x and OS-X, as well as Win2K. It's working correctly in all three.

Removing "fixed1.0.0" since this has been verified on the branch and trunk builds and it is also marked as "verified 1.0.0" as well as "Verified/Fixed".