Closed
Bug 1386303
Opened 7 years ago
Closed 7 years ago
clean up NS_STYLE_AZIMUTH_* constants
Categories
(Core :: Layout, defect, P3)
Tracking
()
RESOLVED
DUPLICATE
of bug 1386326
People
(Reporter: akriti.v10, Unassigned)
Details
Attachments
(3 files, 1 obsolete file)
|
(deleted),
text/x-chdr
|
Details | |
|
(deleted),
patch
|
Details | Diff | Splinter Review | |
|
(deleted),
text/rust
|
Details |
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:54.0) Gecko/20100101 Firefox/54.0
Build ID: 20170612122310
Steps to reproduce:
Have Created a new enum class 'Azimuth' for a set of #define constants.
Have made changes to nsStyleConsts.h , structs_debug.rs ,structs_release.rs
|
Reporter | |
Comment 1•7 years ago
|
||
|
|
Reporter | |
Comment 2•7 years ago
|
||
|
||
Updated•7 years ago
|
Component: Untriaged → General
Product: Firefox → Core
|
||
Updated•7 years ago
|
Component: General → Layout
|
||
Updated•7 years ago
|
Priority: -- → P3
| Comment hidden (mozreview-request) |
|
||
Comment 4•7 years ago
|
||
As noted over in bug 1386326 comment 1, it looks like NS_STYLE_AZIMUTH_* constants are simply unused, so we should just remove them. Would you be interested in posting a patch to do that?
Status: UNCONFIRMED → NEW
status-firefox57:
--- → wontfix
status-firefox58:
--- → affected
Ever confirmed: true
Flags: needinfo?(akriti.v10)
Summary: Change #define constants to enum classes → clean up NS_STYLE_AZIMUTH_* constants
|
|
||
Comment 5•7 years ago
|
||
Oh, it looks like bug 1386326 is already removing them! great. I'll just dupe this over to that one.
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
wontfix → ---
status-firefox58:
affected → ---
Flags: needinfo?(akriti.v10)
Resolution: --- → DUPLICATE
|
||
Updated•7 years ago
|
Attachment #8910665 -
Attachment is obsolete: true
You need to log in
before you can comment on or make changes to this bug.
Description
•