Closed
Bug 1386477
Opened 7 years ago
Closed 7 years ago
Turning on the 'layout.display-list.dump-content' may cause crash in layers-free mode
Categories
(Core :: Graphics: WebRender, enhancement)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: ethlin, Assigned: ethlin)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
That's because we should check if the root is nullptr at[1].
[1] https://dxr.mozilla.org/mozilla-central/source/layout/base/nsLayoutUtils.cpp#3789
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
(In reply to Ethan Lin[:ethlin] from comment #0)
> [1]
> https://dxr.mozilla.org/mozilla-central/source/layout/base/nsLayoutUtils.
> cpp#3789
Please use permalinks when linking to code in bugs. This link is already out of date.
|
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8892721 [details]
Bug 1386477 - Add nullptr check for layerManager->GetRoot() to prevent crash when dumping display list data.
https://reviewboard.mozilla.org/r/163716/#review169226
Attachment #8892721 -
Flags: review?(bugmail) → review+
|
Assignee | |
Comment 4•7 years ago
|
||
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #2)
> (In reply to Ethan Lin[:ethlin] from comment #0)
> > [1]
> > https://dxr.mozilla.org/mozilla-central/source/layout/base/nsLayoutUtils.
> > cpp#3789
>
> Please use permalinks when linking to code in bugs. This link is already out
> of date.
Okay, I will use permalinks next time, like this: https://dxr.mozilla.org/mozilla-central/rev/52285ea5e54c73d3ed824544cef2ee3f195f05e6/layout/base/nsLayoutUtils.cpp#3796.
Pushed by ethlin@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/787a68a754f2
Add nullptr check for layerManager->GetRoot() to prevent crash when dumping display list data. r=kats
|
||
Updated•7 years ago
|
Blocks: stage-wr-next
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•