Closed Bug 1386499 Opened 7 years ago Closed 7 years ago

Remove some nsXPIDLCString uses from nsComponentManager

Categories

(Core :: XPCOM, enhancement)

Product:
Core
Component:
XPCOM
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla57
Tracking Flags:
Tracking Status
firefox57 --- fixed

People

(Reporter: n.nethercote, Assigned: n.nethercote)

References

Details

Attachments

(1 file)

Remove some nsXPIDLCString uses from nsComponentManager
(deleted), patch
erahm
: review+
Details | Diff | Splinter Review
Just a few simple cases here.
ToProvidedString() is a better fit for this code, anyway.
Attachment #8892737 - Flags: review?(erahm)
Blocks: 1377356
Comment on attachment 8892737 [details] [diff] [review] Remove some nsXPIDLCString uses from nsComponentManager Review of attachment 8892737 [details] [diff] [review]: ----------------------------------------------------------------- This seems fine, I assume you tested compiling with that #if enabled?
Attachment #8892737 - Flags: review?(erahm) → review+
I did! :)
Pushed by nnethercote@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f01b2181fe13 Remove some nsXPIDLCString uses from nsComponentManager. r=erahm.
https://hg.mozilla.org/mozilla-central/rev/f01b2181fe13
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: