Closed Bug 1386724 Opened 7 years ago Closed 7 years ago

devtools/client/framework/test/browser_dynamic_tool_enabling.js fails when running locally

Categories

(DevTools :: Framework, enhancement)

Product:
DevTools
Component:
Framework
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox57 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 57
Tracking Flags:
Tracking Status
firefox57 --- fixed

People

(Reporter: bgrins, Assigned: bgrins)

References

Details

Attachments

(1 file)

Bug 1386724 - Force devtools-browser to be loaded in shared-head.js;
(deleted), text/x-review-board-request
jdescottes
: review+
Details
If no other tests run before browser_dynamic_tool_enabling.js then it fails. We had some bad luck with https://bugzilla.mozilla.org/show_bug.cgi?id=1380709#c24, in which a patch forced this test to be the first in a chunk and we hit this issue.
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Comment on attachment 8892982 [details] Bug 1386724 - Force devtools-browser to be loaded in shared-head.js; https://reviewboard.mozilla.org/r/163986/#review169292 LGTM, thanks!
Attachment #8892982 - Flags: review?(jdescottes) → review+
Pushed by bgrinstead@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/26ce8836a4c8 Force devtools-browser to be loaded in shared-head.js;r=jdescottes
https://hg.mozilla.org/mozilla-central/rev/26ce8836a4c8
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
https://hg.mozilla.org/projects/date/rev/26ce8836a4c88c94c68db5f42bb6d914980a1427 Bug 1386724 - Force devtools-browser to be loaded in shared-head.js;r=jdescottes
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: