Closed
Bug 1386854
Opened 7 years ago
Closed 6 years ago
Use diagnostic assertions for SchedulerGroup validation
Categories
(Core :: DOM: Content Processes, enhancement, P3)
Core
DOM: Content Processes
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: billm, Assigned: billm)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
Currently we use a DEBUG-mode assert here:
http://searchfox.org/mozilla-central/rev/f0e4ae5f8c40ba742214e89aba3f554da0b89a33/xpcom/threads/SchedulerGroup.h#81
The correctness of Quantum DOM scheduling relies on labeling being correct, so it would be good to start using real assertions here to catch problems in the wild. We couldn't do this with legacy add-ons around since they could violate the assertions. Now we can do it.
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8893130 -
Flags: review?(bugs)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8893130 [details] [diff] [review]
patch
Scary :) (but needed.)
Attachment #8893130 -
Flags: review?(bugs) → review+
|
||
Updated•7 years ago
|
Priority: -- → P3
|
||
Comment 3•6 years ago
|
||
There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:billm, could you have a look please?
Flags: needinfo?(bill.mccloskey)
|
||
Updated•6 years ago
|
Flags: needinfo?(bill.mccloskey) → needinfo?(bugs)
|
|
||
Comment 4•6 years ago
|
||
There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:billm, could you have a look please?
Flags: needinfo?(bill.mccloskey)
|
|
||
Updated•6 years ago
|
Flags: needinfo?(bill.mccloskey)
|
|
||
Comment 5•6 years ago
|
||
I'm just going to WONTFIX this to hopefully stop the bot needinfos for now.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
|
|
||
Comment 6•4 years ago
|
||
Clearing the needinfo since most of the qdom code has been removed.
Flags: needinfo?(bugs)
You need to log in
before you can comment on or make changes to this bug.
Description
•