Pushed by yura.zenevich@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e6ac32ef78d3 improved accessibliity of onboarding notification bar. r=mossop

Backed out for for linting failure at onboarding.js:984 and failing browser-chrome's browser_onboarding_accessibility.js: Bug 1377283 https://hg.mozilla.org/integration/mozilla-inbound/rev/abb7505076b5392b0f30ac24df3e9f30898a8741 Bug 1377298 https://hg.mozilla.org/integration/mozilla-inbound/rev/a2eccfad14bc9e298e3d41886159520b0ade6c01 Bug 1377276 https://hg.mozilla.org/integration/mozilla-inbound/rev/a0f20d5569dc4f0fb99cc04c854fe11c5e88a51b Bug 1387057 https://hg.mozilla.org/integration/mozilla-inbound/rev/aaa84b4bcd4d7d7626e037dfaf89a617a2b8ba2e Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=e6ac32ef78d3c9493a2cfe9313aef9be47b10b77&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel Failure log eslint: https://treeherder.mozilla.org/logviewer.html#?job_id=120897921&repo=mozilla-inbound > TEST-UNEXPECTED-ERROR | /home/worker/checkouts/gecko/browser/extensions/onboarding/content/onboarding.js:984:5 | Unsafe assignment to innerHTML (no-unsanitized/property) Failure log browser-chrome: https://treeherder.mozilla.org/logviewer.html#?job_id=120902393&repo=mozilla-inbound [task 2017-08-04T05:53:12.472863Z] 05:53:12 INFO - TEST-PASS | browser/extensions/onboarding/test/browser/browser_onboarding_accessibility.js | Content should be visible to screen reader - "true" == "true" - [task 2017-08-04T05:53:12.475728Z] 05:53:12 INFO - Buffered messages finished [task 2017-08-04T05:53:12.478768Z] 05:53:12 INFO - TEST-UNEXPECTED-FAIL | browser/extensions/onboarding/test/browser/browser_onboarding_accessibility.js | Focus should be on the first tour item - {} == {} - [task 2017-08-04T05:53:12.481486Z] 05:53:12 INFO - Stack trace: [task 2017-08-04T05:53:12.488560Z] 05:53:12 INFO - resource://testing-common/content-task.js line 52 > eval:null:11 [task 2017-08-04T05:53:12.490251Z] 05:53:12 INFO - resource://testing-common/content-task.js:null:53 [task 2017-08-04T05:53:12.493159Z] 05:53:12 INFO - Not taking screenshot here: see the one that was previously logged [task 2017-08-04T05:53:12.496281Z] 05:53:12 INFO - TEST-UNEXPECTED-FAIL | browser/extensions/onboarding/test/browser/browser_onboarding_accessibility.js | Overlay button focus state is saved correctly - "undefined" == "true" - [task 2017-08-04T05:53:12.499231Z] 05:53:12 INFO - Stack trace: [task 2017-08-04T05:53:12.504917Z] 05:53:12 INFO - resource://testing-common/content-task.js line 52 > eval:null:13 [task 2017-08-04T05:53:12.508518Z] 05:53:12 INFO - resource://testing-common/content-task.js:null:53 [task 2017-08-04T05:53:12.510420Z] 05:53:12 INFO - Close the dialog and check modal dialog state

Pushed by yura.zenevich@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/b52b9809a8ef improved accessibliity of onboarding notification bar. r=mossop

I believe this one will now stick so removing ni?

Comment on attachment 8893463 [details] [diff] [review] 1387057 notification bar a11y v1 This is one of several bugs that make onboarding accessible to keyboard and screen reader users. [Feature/Bug causing the regression]: None [User impact if declined]: Users who use accessibility services or keyboard would not be able to use onboarding. [Is this code covered by automated tests?]: Yes [Has the fix been verified in Nightly?]: No [Needs manual test from QE? If yes, steps to reproduce]: * Keyboard focus should be visible for all focusable-with-keyboard controls within the notification footer. * If using a screen reader (such as narrator/NVDA in windows or voice over in OSX that support live regions) when the notification is shown, the user should get a verbal notification that the footer is visible. [List of other uplifts needed for the feature/fix]: not for this bug, but all onboarding accessibility bugs are listed in bug 1377300 [Is the change risky?]: No [Why is the change risky/not risky?]: Only affects users that use keyboard [String changes made/needed]: none

Comment on attachment 8893463 [details] [diff] [review] 1387057 notification bar a11y v1 Improve a11y for the onboarding tour in 56. Please uplift to beta.

Not sure if it was this or bug 1387057, but browser_onboarding_tours.js started to permafail after they were uplifted to Beta. Backed out. https://hg.mozilla.org/releases/mozilla-beta/rev/d6bca1edd1bc https://treeherder.mozilla.org/logviewer.html#?job_id=124750713&repo=mozilla-beta

posted try with rebased commits in bug 1377300

I can confirm this issue is fixed, I reproduced it with Fx 57.0a1 (build ID: 20170802100302) on Windows 10 x64. I verified using Fx 57.0a1 (2017-09-01) and Fx 56.0b8, on Windows 10 x64, mac OS X 10.12.6 and Ubuntu 14.04 LTS. Cheers!

I have verified that this issue works as expected on Win 10 x64, Win 7 x86, Mac 10.13, & Ubuntu 16.04 x32 with Firefox 58.