Closed
Bug 1387059
Opened 7 years ago
Closed 7 years ago
Can't click on Play button on Soundcloud station
Categories
(Core :: Layout, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox55 | --- | unaffected |
firefox56 | --- | fixed |
firefox57 | --- | fixed |
People
(Reporter: regnetcc, Assigned: mattwoodrow)
References
(Regressed 1 open bug)
Details
(Keywords: regression, Whiteboard: [webcompat])
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
mstange
:
review+
gchang
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20170803100352
Steps to reproduce:
Go to URL https://soundcloud.com/stations/track/bin-can/tim-mot-nguoi-nhu-the-nguyen-ngoc-anh
or start any station of the track
Actual results:
Can't click on Play button to play the station
Expected results:
Play should clickable and music on
Comment 1•7 years ago
|
||
regression range:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=958d2a5d10091401fd5e900e8e063d21940c137e&tochange=7f894f791cdf170d788507d0eff30024ce699523
unfortunately it hits bustage around there and I cannot bisect more.
then, the issue doesn't happen on e18cf63f9984 on autoland, that is the first build after b266a8d8fd59 there.
so maybe Bug 1361970 or Bug 1359709?
(or perhaps the backout of bug 1370430?)
mattwoodrow, do you have any ideas?
Component: Untriaged → Layout
Flags: needinfo?(matt.woodrow)
Keywords: regression
Product: Firefox → Core
Updated•7 years ago
|
status-firefox55:
--- → unaffected
status-firefox56:
--- → affected
status-firefox57:
--- → affected
Updated•7 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Whiteboard: [webcompat]
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → matt.woodrow
Flags: needinfo?(matt.woodrow)
Assignee | ||
Comment 2•7 years ago
|
||
We want to know if the frame for the inner nsDisplayTransform is participating in the preserve-3d context, not the parent frame (with the perspective property).
Attachment #8895205 -
Flags: review?(mstange)
Comment 3•7 years ago
|
||
This needs a test.
Updated•7 years ago
|
Priority: -- → P2
Comment 4•7 years ago
|
||
(In reply to Markus Stange [:mstange] from comment #3)
> This needs a test.
Hey Matt, just making sure you saw this.
Flags: needinfo?(matt.woodrow)
Assignee | ||
Comment 5•7 years ago
|
||
Attachment #8895205 -
Attachment is obsolete: true
Attachment #8895205 -
Flags: review?(mstange)
Flags: needinfo?(matt.woodrow)
Attachment #8899628 -
Flags: review?(mstange)
Comment 6•7 years ago
|
||
Comment on attachment 8899628 [details] [diff] [review]
Check the right frame for preserve-3d
Review of attachment 8899628 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks!
Attachment #8899628 -
Flags: review?(mstange) → review+
Pushed by mwoodrow@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/61a168afa436
When checking if nsDisplayPerspective participates in preserve-3d, check the underlying transformed frame. r=mstange
Comment 8•7 years ago
|
||
Backed out for unexpectedly passing web-platform-reftest /css/css-transforms-2/transform3d-sorting-001.html:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bb7ce98c2f4ad9630c90be4ba96f80a58bbe2718
Push which ran "failing" tests: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=4d4296e650423faa07ef7ed55cbac7ab5a1c6f05&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
"Failure" log: https://treeherder.mozilla.org/logviewer.html#?job_id=125793275&repo=mozilla-inbound
> TEST-UNEXPECTED-PASS | /css/css-transforms-2/transform3d-sorting-001.html | Testing http://web-platform.test:8000/css/css-transforms-2/transform3d-sorting-001.html == http://web-platform.test:8000/css/css-transforms-2/transform-lime-square-ref.html
Flags: needinfo?(matt.woodrow)
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/88f5063707d2
When checking if nsDisplayPerspective participates in preserve-3d, check the underlying transformed frame. r=mstange
Comment 10•7 years ago
|
||
Relanded because issue persisted and backed out bug 1381753 instead.
Flags: needinfo?(matt.woodrow)
Comment 11•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Comment 12•7 years ago
|
||
Please request Beta approval on this when you get a chance.
status-firefox-esr52:
--- → unaffected
Flags: needinfo?(matt.woodrow)
Comment 13•7 years ago
|
||
Matt, do you have a chance to create the uplift request?
Assignee | ||
Comment 14•7 years ago
|
||
Comment on attachment 8899628 [details] [diff] [review]
Check the right frame for preserve-3d
Approval Request Comment
[Feature/Bug causing the regression]: Bug 1359709
[User impact if declined]: Incorrect hit testing for some complex preserve-3d/perspective scenes.
[Is this code covered by automated tests?]: Yes, new test added.
[Has the fix been verified in Nightly?]: Yes.
[Needs manual test from QE? If yes, steps to reproduce]: Nope
[List of other uplifts needed for the feature/fix]: None.
[Is the change risky?]: No
[Why is the change risky/not risky?]: Very low risk, only affects very specific 3d hit testing code.
[String changes made/needed]: None.
Flags: needinfo?(matt.woodrow)
Attachment #8899628 -
Flags: approval-mozilla-beta?
Comment 15•7 years ago
|
||
Comment on attachment 8899628 [details] [diff] [review]
Check the right frame for preserve-3d
Fix a regression. Beta56+.
Attachment #8899628 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 16•7 years ago
|
||
bugherder uplift |
Flags: in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•