Closed
Bug 1387253
Opened 7 years ago
Closed 7 years ago
Remove custom styling for <toolbarbutton type="menu-button"> in the navigation and tab toolbars
Categories
(Firefox :: Theme, enhancement)
Firefox
Theme
Tracking
()
RESOLVED
FIXED
Firefox 57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: dao, Assigned: dao)
References
Details
Attachments
(1 file)
WebExtensions can't add such buttons we've removed our only one (the combined star and bookmarks menu button).
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8893588 [details]
Bug 1387253 - Remove custom styling for <toolbarbutton type=menu-button> in the navigation and tab toolbars.
https://reviewboard.mozilla.org/r/164668/#review170226
::: browser/themes/shared/toolbarbuttons.inc.css:85
(Diff revision 2)
> -.toolbarbutton-1 > .toolbarbutton-menubutton-button > .toolbarbutton-icon {
> margin-inline-end: 0;
> }
>
> -:-moz-any(toolbar, .widget-overflow-list) .toolbarbutton-1 > .toolbarbutton-icon,
> -:-moz-any(toolbar, .widget-overflow-list) .toolbarbutton-1 > :-moz-any(.toolbarbutton-menubutton-button, .toolbarbutton-badge-stack) > .toolbarbutton-icon,
> +:-moz-any(toolbar, .widget-overflow-list) .toolbarbutton-1 > .toolbarbutton-badge-stack > .toolbarbutton-icon,
> +:-moz-any(toolbar, .widget-overflow-list) .toolbarbutton-1 > .toolbarbutton-icon {
Nit: If you reverse the order you can avoid touching hg blame.
Attachment #8893588 -
Flags: review?(jhofmann) → review+
| Comment hidden (mozreview-request) |
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4269e394aa94
Remove custom styling for <toolbarbutton type=menu-button> in the navigation and tab toolbars. r=johannh
|
Assignee | |
Updated•7 years ago
|
Flags: qe-verify-
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
|
||
Updated•7 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•