Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Description • 7 years ago

+++ This bug was initially created as a clone of Bug #1374207 +++

nsIEditor and other related interfaces will be builtin classes after fixing bug 1060051.  Then, all editor instances are guaranteed that the instances are TextEditor or HTMLEditor.  Then, we can reduce a lot of virtual calls with accessing them via pointer to concrete class.

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 1 • 7 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9be7f9b8efb17e488ae8b1c26e8c8dbaebf74168

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 2 • 7 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=366a303a745c1e88a3e33e1a7dfa89abe31ef676

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 3 • 7 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6e0c6bbdbce151014bc8169969dbb1c9329f89f5

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 4 • 7 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=74088e9bceb64be8903e6c09fc135290af1dd512

	Makoto Kato [:m_kato]
	Comment 10 • 7 years ago
mozreview-review

Comment on attachment 8897278 [details]
Bug 1387317 - part1: Make AutoSelectionSetterAfterTableEdit use HTMLEditor instead of nsITableEditor

https://reviewboard.mozilla.org/r/168570/#review173898

	Makoto Kato [:m_kato]
	Comment 11 • 7 years ago
mozreview-review

Comment on attachment 8897279 [details]
Bug 1387317 - part2: EditorEventListener should stop using interface methods as far as possible

https://reviewboard.mozilla.org/r/168572/#review173938

	Makoto Kato [:m_kato]
	Comment 12 • 7 years ago
mozreview-review

Comment on attachment 8897280 [details]
Bug 1387317 - part3: HTMLEditor should use RefPtr<HTMLEditor> rather than nsCOMPtr<nsIHTMLEditor> for kungFuDeathGrip

https://reviewboard.mozilla.org/r/168574/#review173940

	Makoto Kato [:m_kato]
	Comment 13 • 7 years ago
mozreview-review

Comment on attachment 8897281 [details]
Bug 1387317 - part4: Make editor flag setters use new AddFlags() or RemoveFlags() if useful

https://reviewboard.mozilla.org/r/168576/#review173944

	Makoto Kato [:m_kato]
	Comment 14 • 7 years ago
mozreview-review

Comment on attachment 8897282 [details]
Bug 1387317 - part5: AutoPlaceHolderBatch should take EditorBase instead of nsIEditor

https://reviewboard.mozilla.org/r/168578/#review173956

	Pulsebot
	Comment 15 • 7 years ago

Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/c88f2794e675
part1: Make AutoSelectionSetterAfterTableEdit use HTMLEditor instead of nsITableEditor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/eda3fcc1e872
part2: EditorEventListener should stop using interface methods as far as possible r=m_kato
https://hg.mozilla.org/integration/autoland/rev/052c275f3166
part3: HTMLEditor should use RefPtr<HTMLEditor> rather than nsCOMPtr<nsIHTMLEditor> for kungFuDeathGrip r=m_kato
https://hg.mozilla.org/integration/autoland/rev/de61ab519b71
part4: Make editor flag setters use new AddFlags() or RemoveFlags() if useful r=m_kato
https://hg.mozilla.org/integration/autoland/rev/b131a336d02f
part5: AutoPlaceHolderBatch should take EditorBase instead of nsIEditor r=m_kato

	Carsten Book [:Tomcat]
	Comment 16 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/c88f2794e675
https://hg.mozilla.org/mozilla-central/rev/eda3fcc1e872
https://hg.mozilla.org/mozilla-central/rev/052c275f3166
https://hg.mozilla.org/mozilla-central/rev/de61ab519b71
https://hg.mozilla.org/mozilla-central/rev/b131a336d02f