Closed Bug 1387456 Opened 7 years ago Closed 7 years ago

square photon tabs have a single pixel of space to the left of first tab

Categories

(Firefox :: Theme, defect, P1)

Product:
Firefox
Component:
Theme
Version:
57 Branch
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 57
Iteration:
57.1 - Aug 15
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox55 --- unaffected
firefox56 --- unaffected
firefox57 --- verified

People

(Reporter: bkelly, Assigned: dao)

References

Details

(Whiteboard: [reserve-photon-visual][p3])

Attachments

(2 files)

Screenshot 2017-08-04 10.24.58.png
(deleted), image/png
Details
Bug 1387456 - Remove the first tab's start border when the window is maximized/fullscreen.
(deleted), text/x-review-board-request
johannh
: review+
Details
Attached image Screenshot 2017-08-04 10.24.58.png (deleted) —
With the new photon tabs I noticed there is a sliver of space to the left of the first tab. Obviously pretty minor, but I thought I would file in case this was not intentional. See attached screenshot.
I noticed this when the window was maximized on win10. Obviously the grab bar space when not maximized hides this otherwise.
Whiteboard: [photon-visual][triage]
Whiteboard: [photon-visual][triage] → [reserve-photon-visual][p3]
Flags: qe-verify?
Priority: -- → P3
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Flags: qe-verify? → qe-verify+
Priority: P3 → P1
Iteration: --- → 57.1 - Aug 15
QA Contact: brindusa.tot
Comment on attachment 8895046 [details] Bug 1387456 - Remove the first tab's start border when the window is maximized/fullscreen. https://reviewboard.mozilla.org/r/166174/#review171710
Attachment #8895046 - Flags: review?(jhofmann) → review+
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d973cec5aa53 Remove the first tab's start border when the window is maximized/fullscreen. r=johannh
https://hg.mozilla.org/mozilla-central/rev/d973cec5aa53
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
I have reproduced this bug with Nightly 57.0a1 (2017-08-04) on Windows 8.1 , 64 Bit ! This bug's fix is Verified with latest Nightly ! Build ID 20170811100330 User Agent Mozilla/5.0 (Windows NT 6.3; WOW64; rv:57.0) Gecko/20100101 Firefox/57.0 [bugday-20170809]
With johannh's fix, the first tab doesn't have the start border even if there's an something before it in the tabbar. See this: https://i.imgur.com/srzl0F5.png
(In reply to Rodrigo from comment #7) > With johannh's fix, the first tab doesn't have the start border even if > there's an something before it in the tabbar. See this: > https://i.imgur.com/srzl0F5.png Covered by bug 1390025, I think.
I'm confirming that bug is fixed, starting in Mozilla Firefox Nightly 57.0a1 (2017-08-11), so I'm marking this bug as VERIFIED. Thanks.
Status: RESOLVED → VERIFIED
status-firefox57: fixed → verified
QA Contact: brindusa.tot → Virtual
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: