Closed Bug 1387463 Opened 7 years ago Closed 7 years ago

Pressing escape should close the onboarding tour

Categories

(Firefox :: New Tab Page, defect, P3)

Product:
Firefox
Component:
New Tab Page
Type:
defect

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1377276
Milestone:
Firefox 57

People

(Reporter: mstanke, Unassigned, Mentored)

References

Details

(Keywords: good-first-bug, nightly-community)

Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0 ID:20170804100354 CSet: 32083f24a1bb2c33050b4c972783f066432194eb STR: 1) Open about:newtab. 2) Click the fox/bubble in the top left corner to open the tour. 3) Press Escape. 4) Nothing happens. Instead the tour should close - all similar windows, e.g. Colour or Language settings in about:preferences do close when pressing Escape.
Keywords: nightly-community
Whiteboard: [photon-onboarding]
Not sure how onboarding team is tracking new issues but most seem to be tracked under Firefox / New Tab Page or General.
Component: Activity Streams: Newtab → New Tab Page
thanks we use whiteboard to tracking new issues, we can fix this after bug 1377298 is landed
Depends on: 1377298
Flags: qe-verify+
Priority: -- → P3
Target Milestone: --- → Firefox 57
What need to do here is add "Escape" keyevent in `handleKeypress` method after bug 1377298 is landed, and call `this.toggleOverlay()` to dismiss the overlay.
Mentor: gasolin
Keywords: good-first-bug
it's been fixed in bug 1377276
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
remove whiteboard tag due to its DUPLICATE
Whiteboard: [photon-onboarding]
You need to log in before you can comment on or make changes to this bug.