Title says it all; but in beta and central, configure fails: 0:24.32 ERROR: Could not find the clang shared library in the path /usr/local/lib 0:24.32 returned by `llvm-config --libdir` (searched for files [u'libclang.so.1.0']). 0:24.32 Please check your system configuration. openbsd is not linux, and libclang.so *will* have a varying .so version (right now it's 5.0), so whatever the python code added in https://hg.mozilla.org/integration/mozilla-inbound/rev/cc58f2b74c4f is doing, it should match libclang.so.*...

This sorta works (also needs to import glob..) if host.kernel == 'Linux': libclang_choices.append('libclang.so.1') + if host.os == 'OpenBSD': + libclang_choices = glob.glob(path + '/libclang.so.*.*') + # At least one of the choices must be found.

(In reply to Landry Breuil (:gaston) from comment #1) > This sorta works (also needs to import glob..) > > if host.kernel == 'Linux': > libclang_choices.append('libclang.so.1') > > + if host.os == 'OpenBSD': > + libclang_choices = glob.glob(path + '/libclang.so.*.*') > + > # At least one of the choices must be found. Assuming that this works to pass configure *and* build with stylo -- not sure if clang-sys is set up to handle OpenBSD's constantly varying .so versions -- r=me.

I'm not sure for clang-sys nor runtime, but at least with this configure passed and m-i built (with --enable-stylo in .mozconfig)

Comment on attachment 8893949 [details] [diff] [review] bug-1387510 Review of attachment 8893949 [details] [diff] [review]: ----------------------------------------------------------------- If you say it builds, I'm happy. Thank you!

I've hit this with self-built libclang on linux or macOS as well. It's just that distro-installed versions typically have a symlink to libclang.so, but if we search for libclang.so.1 we might as well search for .4 and .5 too.

Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ab81d3d87d87 Use glob() when looking for libclang.so on OpenBSD. r=froydnj

(In reply to Ralph Giles (:rillian) | needinfo me from comment #5) > I've hit this with self-built libclang on linux or macOS as well. It's just > that distro-installed versions typically have a symlink to libclang.so, but > if we search for libclang.so.1 we might as well search for .4 and .5 too. that's a slightly different thing - hardcoding .4 or .5 *will* fail at some point on OpenBSD, as we keep bumping libclang major when it's updated and functions are removed/changed in it - hence globbing...

Comment on attachment 8893949 [details] [diff] [review] bug-1387510 Approval Request Comment [Feature/Bug causing the regression]: 1363655 [User impact if declined]: FTBFS on OpenBSD [Is this code covered by automated tests?]: yes, http://buildbot.rhaalovely.net/builders/ [Has the fix been verified in Nightly?]: Yes [Needs manual test from QE? If yes, steps to reproduce]: No [List of other uplifts needed for the feature/fix]: None [Is the change risky?]: No [Why is the change risky/not risky?]: NPOTB/Tier3 [String changes made/needed]: None

Comment on attachment 8893949 [details] [diff] [review] bug-1387510 Build fix, let's uplift for 56 beta 1.