Gregory Szorc [:gps] Assignee
	Description • 7 years ago

To help with forensics.

	:glob ✱
	Comment 2 • 7 years ago
mozreview-review

Comment on attachment 8894024 [details]
vcsreplicator: log output from Mercurial commands (bug 1387645);

https://reviewboard.mozilla.org/r/165120/#review170620

::: pylib/vcsreplicator/vcsreplicator/consumer.py:262
(Diff revision 1)
>  
>          logger.warn('pulling %d heads into %s' % (
>              len(heads), local_path))
> -        c.pull(source=url or 'default', rev=heads)
> +        args = hglib.util.cmdbuilder('pull', url or 'default', r=heads)
> +        res, out, err = run_command(c, args)
> +        if res not in (0, 1):

i'm not sure why unresolved files (ret==1) are treated as success here.

	Gregory Szorc [:gps] Assignee
	Comment 3 • 7 years ago
mozreview-review-reply

Comment on attachment 8894024 [details]
vcsreplicator: log output from Mercurial commands (bug 1387645);

https://reviewboard.mozilla.org/r/165120/#review170620

> i'm not sure why unresolved files (ret==1) are treated as success here.

This is (surprisingly) the default behavior of hglib.util.reterrorhandler(), which hglib.client.hgclient.pull() uses. But, yeah, it is wonky. I'll fix it in flight.

	Pulsebot
	Comment 5 • 7 years ago

Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/2c697760447f
vcsreplicator: log output from Mercurial commands ; r=glob

	Pulsebot
	Comment 6 • 7 years ago

Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/5887f2360442
vcsreplicator: log process output at higher log level