[Tracking Requested - why for this release]: startup crash regression in firefox 55 triggered by Cookie Controller 6.0 update on august 4th. This bug was filed from the Socorro interface and is report bp-8b43c716-7501-45e0-b8fc-de4e30170805. ============================================================= Crashing Thread (0) Frame Module Signature Source 0 xul.dll js::ExecuteInGlobalAndReturnScope(JSContext*, JS::Handle<JSObject*>, JS::Handle<JSScript*>, JS::MutableHandle<JSObject*>) js/src/builtin/Eval.cpp:454 1 xul.dll nsMessageManagerScriptExecutor::LoadScriptInternal(nsAString const&, bool) dom/base/nsFrameMessageManager.cpp:1567 2 xul.dll nsInProcessTabChildGlobal::LoadFrameScript(nsAString const&, bool) dom/base/nsInProcessTabChildGlobal.cpp:353 3 xul.dll nsAsyncScriptLoad::Run() dom/base/nsInProcessTabChildGlobal.cpp:332 4 xul.dll nsContentUtils::RemoveScriptBlocker() dom/base/nsContentUtils.cpp:5636 5 xul.dll mozilla::PresShell::Initialize(int, int) layout/base/PresShell.cpp:1821 6 xul.dll mozilla::dom::XULDocument::StartLayout() dom/xul/XULDocument.cpp:1941 7 xul.dll mozilla::dom::XULDocument::DoneWalking() dom/xul/XULDocument.cpp:3031 8 xul.dll mozilla::dom::XULDocument::ResumeWalk() dom/xul/XULDocument.cpp:2977 9 xul.dll mozilla::dom::XULDocument::OnScriptCompileComplete(JSScript*, nsresult) dom/xul/XULDocument.cpp:3473 10 xul.dll NotifyOffThreadScriptCompletedRunnable::Run() dom/xul/nsXULElement.cpp:2667 11 xul.dll nsThread::ProcessNextEvent(bool, bool*) xpcom/threads/nsThread.cpp:1446 12 xul.dll NS_ProcessNextEvent(nsIThread*, bool) xpcom/threads/nsThreadUtils.cpp:480 13 xul.dll mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) ipc/glue/MessagePump.cpp:125 14 xul.dll MessageLoop::RunHandler() ipc/chromium/src/base/message_loop.cc:319 15 xul.dll MessageLoop::Run() ipc/chromium/src/base/message_loop.cc:299 16 xul.dll nsBaseAppShell::Run() widget/nsBaseAppShell.cpp:156 17 xul.dll nsAppShell::Run() widget/windows/nsAppShell.cpp:278 18 xul.dll nsAppStartup::Run() toolkit/components/startup/nsAppStartup.cpp:287 19 xul.dll XREMain::XRE_mainRun() toolkit/xre/nsAppRunner.cpp:4608 20 xul.dll XREMain::XRE_main(int, char** const, mozilla::BootstrapConfig const&) toolkit/xre/nsAppRunner.cpp:4772 21 xul.dll XRE_main(int, char** const, mozilla::BootstrapConfig const&) toolkit/xre/nsAppRunner.cpp:4867 22 firefox.exe NS_internal_main(int, char**, char**) browser/app/nsBrowserApp.cpp:309 23 firefox.exe wmain toolkit/xre/nsWindowsWMain.cpp:115 24 firefox.exe __scrt_common_main_seh f:/dd/vctools/crt/vcstartup/src/startup/exe_common.inl:253 Ø 25 kernel32.dll kernel32.dll@0x62b3 Ø 26 ntdll.dll ntdll.dll@0x5fda0 Ø 27 kernelbase.dll kernelbase.dll@0x4cd2f this is a cross-platform startup crash triggered by the update of https://addons.mozilla.org/firefox/addon/cookie-controller/ to version 6.0 on august 4 & it only affects version 55 and upwards - 54 is unaffected. regression testing points towards https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=c21bd752dc66ae708019a4156bbee69123bec4e8&tochange=b658ca8e2aed84bbc9cbeb52b341e7d40588a8bd as patch in the firefox code relevant to regression. those reports commonly are annotated with MOZ_RELEASE_ASSERT(scriptArg->hasNonSyntacticScope()) which was added in bug 1165486. the addon has some 20k users according to amo - can we blocklist the extension version causing the startup crashes (or take other steps to mitigate this) urgently before 55 is being pushed to the release audience?

forgot to add: the issue is easily reproducible in affected builds - install https://addons.mozilla.org/firefox/addon/cookie-controller/versions/?page=1#version-6.0 - restart firefox -> instacrash at startup

We need to make it incompatible for 55 before release day (Tuesday)

A new version has been released two days ago which is supposed to fix the crash issue. Can you confirm it does?

Jorge, I also added a compat-override, could you please review https://addons-internal.prod.mozaws.net/en-US/admin/models/addons/compatoverride/2445/ ?

yes, version 6.1 fixes the startup crash for me.

The correct compat-override is in place now.

when i tried the update path from 54.0.1 to 55.0 while cookie controller 6.0 was installed it led straight into the startup crash - there was no compatibility check before that that would have disabled or updated the addon.

oh sorry, it did work when i tried updating from 54.0b to 55.0rc3. not however from 54.0.1 to 55.0 when i set the update channel to release-cdntest - maybe that's expected under those circumstances (i'm not experienced in update testing)...