According to http://design.firefox.com/people/shorlander/photon/Mockups/windows-10.html the tab separators should be the full height of the titlebar/tabstrip. Right now they're centered with gaps above and below. Windows 10, latest nightly, default theme.

Comment on attachment 8896596 [details] Bug 1387754 - Let tab separators span the full height of the titlebar. https://reviewboard.mozilla.org/r/167874/#review173926 There are two issues from trying out this patch on OSX - The tab separators disappear on tab hover, while they shouldn't according to the mockup (http://design.firefox.com/people/shorlander/photon/Mockups/macOS.html). I thought this looked okay with the smaller separators but with the larger ones it gets really obvious. - There's a 1px overlap with the top window border on OSX. We might have to fine-tune the border-image on OSX a little to remove that. I would be ok with making that a follow-up bug, though. It's your call. Thanks!

Comment on attachment 8897366 [details] Bug 1387754 - Update about:addons icons. Apologies, copy and pasted wrong number

Comment on attachment 8896596 [details] Bug 1387754 - Let tab separators span the full height of the titlebar. https://reviewboard.mozilla.org/r/167874/#review174912 ::: browser/themes/shared/tabs.inc.css:330 (Diff revision 2) > background-repeat: repeat-x; > } > > +.tabbrowser-tab:hover > .tab-stack > .tab-background:not([selected=true]) { > + border-left-style: solid; > + border-right-style: solid; This causes a noticeable (to me at least) flickering when the ::before element goes away and the border appears. Why do we have to use both border and ::before? ::: browser/themes/shared/tabs.inc.css:451 (Diff revision 2) > +} > +%endif > + > /* Also show separators beside the selected tab when dragging it. */ > #tabbrowser-tabs[movingtab] > .tabbrowser-tab[beforeselected]:not([last-visible-tab])::after, > .tabbrowser-tab:not([selected]):not([afterselected-visible]):not([afterhovered]):not([first-visible-tab]):not(:hover)::before, I don't understand why we can't just alter this rule.

(In reply to Johann Hofmann [:johannh] from comment #6) > > /* Also show separators beside the selected tab when dragging it. */ > > #tabbrowser-tabs[movingtab] > .tabbrowser-tab[beforeselected]:not([last-visible-tab])::after, > > .tabbrowser-tab:not([selected]):not([afterselected-visible]):not([afterhovered]):not([first-visible-tab]):not(:hover)::before, > > I don't understand why we can't just alter this rule. Alter how, in a way that works for separators spanning the full title bar height as well as those not doing that?

I'm going to resubmit the original patch so we can get this landed while looking for solutions for other issues related to tab separators.

Comment on attachment 8896596 [details] Bug 1387754 - Let tab separators span the full height of the titlebar. https://reviewboard.mozilla.org/r/167874/#review174932 Thanks! That's a good call, and sorry for the holdup. I'm sure we can get this right following up.

Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e9e0ea3babfc Let tab separators span the full height of the titlebar. r=johannh

User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0 Build ID 20170905100117 This bug fix is Verified with latest Nightly 57.0a1.