Closed
Bug 1387789
Opened 7 years ago
Closed 7 years ago
Convert ExtensionTabs.jsm to an API script
Categories
(WebExtensions :: General, enhancement)
WebExtensions
General
Tracking
(firefox57 fixed)
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: kmag, Assigned: kmag)
References
(Blocks 2 open bugs)
Details
Attachments
(1 file)
Having ExtensionTabs.jsm in a separate compartment prevents effective JIT optimization, and makes things like Tab.convert an order of magnitude slower. After moving it to an ordinary API script, that function disappears from profiles entirely.
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8894141 [details]
Bug 1387789: Convert ExtensionTabs.jsm to ext-tabs-base.js.
https://reviewboard.mozilla.org/r/165206/#review170830
nice
Attachment #8894141 -
Flags: review?(mixedpuppy) → review+
|
Assignee | |
Comment 3•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/814688712ca461dd650e9a4cf80df274effc4a8c
Bug 1387789: Convert ExtensionTabs.jsm to ext-tabs-base.js. r=mixedpuppy
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
|
||
Comment 5•7 years ago
|
||
Is manual testing required on this bug? If yes, please provide some STR and the proper extension(if required) or set the “qe-verify -“ flag.
Thanks!
Flags: needinfo?(kmaglione+bmo)
|
|
Assignee | |
Updated•7 years ago
|
Flags: needinfo?(kmaglione+bmo) → qe-verify-
|
||
Updated•6 years ago
|
Product: Toolkit → WebExtensions
You need to log in
before you can comment on or make changes to this bug.
Description
•