Closed
Bug 1388166
Opened 7 years ago
Closed 7 years ago
Bug 1266836 introduced toolkit/browser dependency (breaks http auth on XUL apps) - follow up
Categories
(Toolkit :: Password Manager, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla57
People
(Reporter: jorgk-bmo, Assigned: jorgk-bmo)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
(deleted),
patch
|
johannh
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1350152 +++
We still need to fix nsLoginManagerPrompter.js" line: 1437 reads:
let tabbrowser = chromeWin.gBrowser || chromeWin.getBrowser();
when chromeWin has no getBrowser() function.
|
Assignee | |
Comment 1•7 years ago
|
||
I don't know whether this fixes the problem, I'd like to get the people from bug 1358313 to try it.
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8894650 [details] [diff] [review]
1388166-login-manager.patch (v1)
Review of attachment 8894650 [details] [diff] [review]:
-----------------------------------------------------------------
r=me on the code, hopefully someone can confirm that this fixes the problem
Attachment #8894650 -
Flags: review?(jhofmann) → review+
|
|
Assignee | |
Comment 3•7 years ago
|
||
Thanks, I'll compile a version with this patch and get it to the reporters of bug 1358313.
|
|
Assignee | |
Comment 4•7 years ago
|
||
This worked, so let's get it landed. Thank you, Johann.
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bf01128ff941
Handle case where chromeWin.getBrowser() doesn't exist. r=johannh
Keywords: checkin-needed
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
|
|
Assignee | |
Comment 7•7 years ago
|
||
Taken to TB branch for TB 56 beta:
https://hg.mozilla.org/releases/mozilla-beta/rev/3566a92f2698ed06ceeb68a2dc6b738c22b49465
|
||
Updated•7 years ago
|
|
|
Assignee | |
Comment 8•7 years ago
|
||
THUNDERBIRD_52_VERBRANCH:
https://hg.mozilla.org/releases/mozilla-esr52/rev/fbb0bdb191d5e2d044ca00615d8c3ad3af7a0ab6
|
|
||
Updated•7 years ago
|
status-thunderbird_esr52:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•