Closed
Bug 1388269
Opened 7 years ago
Closed 7 years ago
Spellchecker should use TextEditor rather than nsIEditor
Categories
(Core :: DOM: Editor, enhancement)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: masayuki, Assigned: masayuki)
References
(Blocks 1 open bug)
Details
Attachments
(4 files)
No description provided.
|
Assignee | |
Comment 1•7 years ago
|
||
|
|
Assignee | |
Comment 2•7 years ago
|
||
|
|
Assignee | |
Comment 3•7 years ago
|
||
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 8•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8897273 [details]
Bug 1388269 - part2: Make mozInlineSpellChecker store TextEditor instead of nsIEditor
https://reviewboard.mozilla.org/r/168558/#review173852
::: extensions/spellcheck/src/mozInlineSpellChecker.cpp:1841
(Diff revision 1)
> -
> + }
> - rv = selection->GetFocusNode(getter_AddRefs(mCurrentSelectionAnchorNode));
> - NS_ENSURE_SUCCESS(rv, rv);
>
> - selection->GetFocusOffset(&mCurrentSelectionOffset);
> + mCurrentSelectionAnchorNode = do_QueryInterface(selection->GetFocusNode());
> + mCurrentSelectionOffset = selection->FocusOffset();
I will file a new bug that mCurrentSelectionAnchorNode changes to nsINode and mCurrentSelectionOffset changes to uint32_t.
Attachment #8897273 -
Flags: review?(m_kato) → review+
|
|
||
Comment 9•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8897274 [details]
Bug 1388269 - part3: spellchecker should use TextEditor instead of nsIEditor
https://reviewboard.mozilla.org/r/168560/#review173860
Attachment #8897274 -
Flags: review?(m_kato) → review+
|
|
||
Comment 10•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8897275 [details]
Bug 1388269 - part4: Make mozInlineSpellChecker::GetSpellCheckSelection() return Selection instead of nsISelection
https://reviewboard.mozilla.org/r/168562/#review173864
Attachment #8897275 -
Flags: review?(m_kato) → review+
|
||
Comment 11•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8897272 [details]
Bug 1388269 - part1: mozInlineSpellChecker should store editor as strong pointer instead of weak pointer
https://reviewboard.mozilla.org/r/168556/#review173888
Attachment #8897272 -
Flags: review?(bugs) → review+
|
||
Comment 12•7 years ago
|
||
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/353c67a074cd
part1: mozInlineSpellChecker should store editor as strong pointer instead of weak pointer r=smaug
https://hg.mozilla.org/integration/autoland/rev/85709484582e
part2: Make mozInlineSpellChecker store TextEditor instead of nsIEditor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/5d275d296b7e
part3: spellchecker should use TextEditor instead of nsIEditor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/3dfde1e86b56
part4: Make mozInlineSpellChecker::GetSpellCheckSelection() return Selection instead of nsISelection r=m_kato
|
||
Comment 13•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/353c67a074cd
https://hg.mozilla.org/mozilla-central/rev/85709484582e
https://hg.mozilla.org/mozilla-central/rev/5d275d296b7e
https://hg.mozilla.org/mozilla-central/rev/3dfde1e86b56
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
|
|
Assignee | |
Updated•5 years ago
|
Blocks: redesign-editor-scriptable-API
You need to log in
before you can comment on or make changes to this bug.
Description
•