Closed
Bug 1388457
Opened 7 years ago
Closed 7 years ago
Compact mode should have higher density navigation toolbar buttons
Categories
(Firefox :: Theme, defect, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | verified |
People
(Reporter: Eddwardiq, Assigned: dao)
References
Details
(Whiteboard: [photon-visual])
Attachments
(2 files)
compact buttons.png
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20170808114032
Steps to reproduce:
Comparing current Nightly and Mockup from here:
http://design.firefox.com/people/shorlander/photon/Mockups/windows-10.html
UI Density: Compact
For a difference see attachment.
|
||
Updated•7 years ago
|
Component: Untriaged → Theme
|
||
Updated•7 years ago
|
Whiteboard: [photon-visual] → [photon-visual] [triage]
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → dao+bmo
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Flags: qe-verify+
Whiteboard: [photon-visual] [triage] → [photon-visual]
| Comment hidden (mozreview-request) |
|
|
||
Updated•7 years ago
|
Iteration: --- → 57.1 - Aug 15
Priority: -- → P1
QA Contact: brindusa.tot
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8895274 [details]
Bug 1388457 - Make toolbar buttons smaller in compact mode.
https://reviewboard.mozilla.org/r/166448/#review172164
Looks good, cheers
Attachment #8895274 -
Flags: review?(dharvey) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5e8ee8c79ba2
Make toolbar buttons smaller in compact mode. r=daleharvey
Dao checking your patch. Toolbar buttons are matching Mockup specs precisely now, however looks like you have also changed the New tab "+" button. Doesn't look good. See here: https://s28.postimg.org/b1p3s1o6l/plus.png
Also, not sure if it was caused by this patch, but in this build the Bookmarks toolbars ">>" overflow button has been changed to the bigger one, similar to other toolbar buttons and it make Bookmarks toolbar quite a lot higher in every density options.
If there is no overflow button, the height changed back to the size mentioned here in bug 1388794#c3
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
|
|
||
Updated•7 years ago
|
QA Contact: brindusa.tot → ovidiu.boca
|
||
Comment 6•7 years ago
|
||
I'm confirming that bug is fixed, starting in Mozilla Firefox Nightly 57.0a1 (2017-08-11), so I'm marking this bug as VERIFIED. Thanks.
|
||
Updated•7 years ago
|
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•