Closed
Bug 1388528
Opened 7 years ago
Closed 7 years ago
The Page action menu should remain visible on the about:newtab and about:home Pages.
Categories
(Firefox :: Menus, defect)
Tracking
()
RESOLVED
WONTFIX
Tracking | Status | |
---|---|---|
firefox57 | --- | affected |
People
(Reporter: bbell, Assigned: adw)
References
(Blocks 1 open bug)
Details
Recently the Page Action Menu disappeared when viewing about:newtab. This change breaks the newtabs' ability to save items to Pocket.
Save to Pocket options in the new tab rely on that function being present in the chrome.
Updated•7 years ago
|
Whiteboard: [photon-structure] → [photon-structure] [triage]
Assignee | ||
Comment 1•7 years ago
|
||
To be clear, we're talking about clicking the "..." button on the big "Recommended by Pocket" tiles, and then clicking "Save to Pocket," right?
Blocks: 1352697
Flags: needinfo?(bbell)
Comment 2•7 years ago
|
||
Yes, clicking the "..." button on the "Recommended by Pocket" tiles, and then clicking "Save to Pocket" option is how you would save an item to Pocket via Activity Stream. What it does when you click "Save to Pocket" is that it looks for the pocket widget in the customize-able toolbar, and then just opens up the door hanger for that, to allow the user to either sign up, or log in or whatever the other options are. Without access to that icon, (and what's currently broken in nightly) the action "Save to Pocket" from Activity Stream's context menu does nothing.
Basically, we need some way to have that door hanger menu come up for Pocket from about:newtab
Flags: needinfo?(bbell)
Comment 3•7 years ago
|
||
(In reply to Ursula Sarracini (:ursula) from comment #2)
> Yes, clicking the "..." button on the "Recommended by Pocket" tiles, and
> then clicking "Save to Pocket" option is how you would save an item to
> Pocket via Activity Stream. What it does when you click "Save to Pocket" is
> that it looks for the pocket widget in the customize-able toolbar, and then
> just opens up the door hanger for that, to allow the user to either sign up,
> or log in or whatever the other options are. Without access to that icon,
> (and what's currently broken in nightly) the action "Save to Pocket" from
> Activity Stream's context menu does nothing.
> Basically, we need some way to have that door hanger menu come up for Pocket
> from about:newtab
I don't see any of this UI. How do I enable it?
Flags: needinfo?(usarracini)
Assignee | ||
Comment 4•7 years ago
|
||
OK, thanks Ursula. I'll take this bug, especially since I broke it.
(In reply to :Gijs from comment #3)
> I don't see any of this UI. How do I enable it?
When you click the gear icon on about:newtab, is "Recommended by Pocket" checked?
Assignee: nobody → adw
Status: NEW → ASSIGNED
Comment 5•7 years ago
|
||
(In reply to Drew Willcoxon :adw from comment #4)
> OK, thanks Ursula. I'll take this bug, especially since I broke it.
>
> (In reply to :Gijs from comment #3)
> > I don't see any of this UI. How do I enable it?
>
> When you click the gear icon on about:newtab, is "Recommended by Pocket"
> checked?
It's not even listed there, presumably because I'm not in the US or something.
Comment 6•7 years ago
|
||
Gijs, yeah Pocket is only being displayed for a handful of geo locations right now. You can toggle it on manually however, in about:config search for "browser.newtabpage.activity-stream.feeds.section.topstories" and set that pref to true. You should be able to get some Pocket stories that way.
Flags: needinfo?(usarracini)
Updated•7 years ago
|
Iteration: --- → 57.1 - Aug 15
Flags: qe-verify?
Priority: -- → P1
Whiteboard: [photon-structure] [triage] → [photon-structure]
Updated•7 years ago
|
Iteration: 57.1 - Aug 15 → ---
Priority: P1 → --
Whiteboard: [photon-structure] → [photon-structure] [triage]
Comment 7•7 years ago
|
||
Mid-air collisions still no fun. :-)
Iteration: --- → 57.1 - Aug 15
Priority: -- → P1
Whiteboard: [photon-structure] [triage] → [photon-structure]
Assignee | ||
Comment 8•7 years ago
|
||
We talked on IRC and decided there are a couple of different bugs here: (1) showing the meatball button on newtab, and (2) updating Pocket's logic that determines where to anchor the Pocket panel. As part of (2), the logic should prefer in order: the Pocket page action urlbar button, the meatball button, the site identity (information) icon. If it turns out we don't want to do (1) after all, or we just don't get around to it, then the logic will just fall back to the site identity icon as a last resort.
Gijs thinks we could do (2) as part of the CUI integration removal in bug 1385418, so I'll take that bug too. (1) is this bug.
Also worth noting:
* The Save to Pocket context menu item is broken too: https://dxr.mozilla.org/mozilla-central/rev/a921bfb8a2cf3db4d9edebe9b35799a3f9d035da/browser/extensions/pocket/bootstrap.js#238-254
* The save/anchor logic is here: http://searchfox.org/mozilla-central/source/browser/extensions/pocket/content/Pocket.jsm#98
Assignee | ||
Comment 9•7 years ago
|
||
After more talk, we decided that actually the page action urlbar buttons should be hidden on all about pages. I filed bug 1388835 for that. We'll still fix the about:newtab Pocket/Activity Stream problem as part of bug 1385418, as I mentioned in comment 8. I'll wontfix this bug.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
Updated•7 years ago
|
Iteration: 57.1 - Aug 15 → ---
Flags: qe-verify?
Priority: P1 → --
Whiteboard: [photon-structure]
You need to log in
before you can comment on or make changes to this bug.
Description
•