Closed Bug 1388627 Opened 7 years ago Closed 7 years ago

Remove obsolete Wait.until() calls from Window Manager Mixin

Categories

(Remote Protocol :: Marionette, enhancement)

Product:
Remote Protocol
Component:
Marionette
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox57 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla57
Tracking Flags:
Tracking Status
firefox57 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

Details

Attachments

(2 files)

Bug 1388627 - Remove obsolete Wait.until() calls from Window Manager Mixin.
(deleted), text/x-review-board-request
automatedtester
: review+
Details
Bug 1388627 - close_chrome_window always operates in chrome context.
(deleted), text/x-review-board-request
automatedtester
: review+
Details
We still have two calls for the window manager mixin which state that those are necessary because close() doesn't wait. This is not true anymore since bug 1311350 has been fixed for Firefox 53. https://dxr.mozilla.org/mozilla-central/source/testing/marionette/harness/marionette_harness/runner/mixins/window_manager.py#44-48 https://dxr.mozilla.org/mozilla-central/source/testing/marionette/harness/marionette_harness/runner/mixins/window_manager.py#65-69 Lets get those removed.
Attachment #8895280 - Flags: review?(ato) → review?(dburns)
Attachment #8895281 - Flags: review?(ato) → review?(dburns)
Comment on attachment 8895280 [details] Bug 1388627 - Remove obsolete Wait.until() calls from Window Manager Mixin. https://reviewboard.mozilla.org/r/166458/#review172388
Attachment #8895280 - Flags: review?(dburns) → review+
Comment on attachment 8895281 [details] Bug 1388627 - close_chrome_window always operates in chrome context. https://reviewboard.mozilla.org/r/166468/#review172390
Attachment #8895281 - Flags: review?(dburns) → review+
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e6f14ea1dbe3 Remove obsolete Wait.until() calls from Window Manager Mixin. r=automatedtester https://hg.mozilla.org/integration/autoland/rev/77865d6f19c1 close_chrome_window always operates in chrome context. r=automatedtester
https://hg.mozilla.org/mozilla-central/rev/e6f14ea1dbe3 https://hg.mozilla.org/mozilla-central/rev/77865d6f19c1
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: