Closed
Bug 1388668
Opened 7 years ago
Closed 7 years ago
AudioDestinationNode uses NS_DispatchToCurrentThread()
Categories
(Core :: Web Audio, enhancement, P3)
Tracking
()
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: cpearce, Assigned: cpearce)
References
Details
Attachments
(1 file)
AudioDestinationNode uses NS_DispatchToCurrentThread():
https://searchfox.org/mozilla-central/rev/0f16d437cce97733c6678d29982a6bcad49f817b/dom/media/webaudio/AudioDestinationNode.cpp#417
We're supposed to be dispatching events to tab groups now so that runnables can be associated with the tab they run in.
I also think that dispatching to the current thread may be a bit awkward when we import WebAudio into Servo. So we should change this dispatch to use a tab group instead. I think just dispatching to AudioNode::AbstractThread() would have this effect.
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8895287 [details]
Bug 1388668 - Replace NS_DispatchToCurrentThread call with AbstractThread dispatch.
https://reviewboard.mozilla.org/r/166482/#review171638
Thanks!
Attachment #8895287 -
Flags: review?(padenot) → review+
Pushed by cpearce@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/47f690ea850a
Replace NS_DispatchToCurrentThread call with AbstractThread dispatch. r=padenot
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•