Closed
Bug 1388724
Opened 7 years ago
Closed 7 years ago
CustomTab: doorhanger not displayed
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(fennec+, firefox55 unaffected, firefox56 unaffected, firefox57 verified)
VERIFIED
FIXED
Firefox 57
Tracking | Status | |
---|---|---|
fennec | + | --- |
firefox55 | --- | unaffected |
firefox56 | --- | unaffected |
firefox57 | --- | verified |
People
(Reporter: sflorean, Assigned: jchen)
References
Details
Attachments
(6 files)
(deleted),
text/x-review-board-request
|
cnevinchen
:
review+
|
Details |
(deleted),
text/x-review-board-request
|
droeh
:
review+
|
Details |
(deleted),
text/x-review-board-request
|
droeh
:
review+
|
Details |
(deleted),
text/x-review-board-request
|
esawin
:
review+
|
Details |
(deleted),
text/x-review-board-request
|
sebastian
:
review+
|
Details |
(deleted),
text/x-review-board-request
|
esawin
:
review+
|
Details |
Environment:
Device: HTC 10 (Android 7.0);
Build: Nightly 57.0a1 (2017-08-09);
Prerequisites: enable Custom tabs in settings.
Steps to reproduce:
1. Go to https://mozilla.github.io/webrtc-landing/gum_test_aec.html from Gmail app;
2. Tap on Audio&video.
Expected result:
A doorhanger is displayed asking to share the microphone and camera.
Actual result:
No doorhanger is displayed.
Notes:
Reproducible also for Facebook login when saving passwords, geolocation etc.
tracking-fennec: ? → +
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → nchen
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8898549 [details]
Bug 1388724 - 5. Make RuntimePermissions not depend on GeckoApp;
https://reviewboard.mozilla.org/r/169918/#review175198
Nice!
Attachment #8898549 -
Flags: review?(s.kaspari) → review+
Comment 8•7 years ago
|
||
mozreview-review |
Comment on attachment 8898545 [details]
Bug 1388724 - 1. Support non-GeckoApp context in DoorHangerPopup;
https://reviewboard.mozilla.org/r/169910/#review175218
Attachment #8898545 -
Flags: review?(cnevinchen) → review+
Comment 9•7 years ago
|
||
mozreview-review |
Comment on attachment 8898548 [details]
Bug 1388724 - 4. Use universal doorhanger API for content permissions;
https://reviewboard.mozilla.org/r/169916/#review175290
Attachment #8898548 -
Flags: review?(esawin) → review+
Comment 10•7 years ago
|
||
mozreview-review |
Comment on attachment 8898550 [details]
Bug 1388724 - 6. Make WebrtcUI not depend on browser.js;
https://reviewboard.mozilla.org/r/169920/#review175292
::: mobile/android/components/BrowserCLH.js:51
(Diff revision 1)
> + XPCOMUtils.defineLazyGetter(this, name, _ => {
> + let sandbox = {};
> + Services.scriptloader.loadSubScript(script, sandbox);
> + return sandbox[name];
> + });
> + let observer = (s, t, d) => {
Please use more descriptive argument names.
Attachment #8898550 -
Flags: review?(esawin) → review+
Comment 11•7 years ago
|
||
mozreview-review |
Comment on attachment 8898546 [details]
Bug 1388724 - 2. Add universal DoorHanger API;
https://reviewboard.mozilla.org/r/169912/#review175394
Attachment #8898546 -
Flags: review?(droeh) → review+
Comment 12•7 years ago
|
||
mozreview-review |
Comment on attachment 8898547 [details]
Bug 1388724 - 3. Add DoorHangerPopup to custom tabs and PWA;
https://reviewboard.mozilla.org/r/169914/#review175398
Attachment #8898547 -
Flags: review?(droeh) → review+
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 19•7 years ago
|
||
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a7d586922755
1. Support non-GeckoApp context in DoorHangerPopup; r=nechen
https://hg.mozilla.org/integration/autoland/rev/8cd05b219a9e
2. Add universal DoorHanger API; r=droeh
https://hg.mozilla.org/integration/autoland/rev/a5a657c11f0c
3. Add DoorHangerPopup to custom tabs and PWA; r=droeh
https://hg.mozilla.org/integration/autoland/rev/485647b7e806
4. Use universal doorhanger API for content permissions; r=esawin
https://hg.mozilla.org/integration/autoland/rev/a412eff66510
5. Make RuntimePermissions not depend on GeckoApp; r=sebastian
https://hg.mozilla.org/integration/autoland/rev/ed85d72cb6dd
6. Make WebrtcUI not depend on browser.js; r=esawin
Comment 20•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a7d586922755
https://hg.mozilla.org/mozilla-central/rev/8cd05b219a9e
https://hg.mozilla.org/mozilla-central/rev/a5a657c11f0c
https://hg.mozilla.org/mozilla-central/rev/485647b7e806
https://hg.mozilla.org/mozilla-central/rev/a412eff66510
https://hg.mozilla.org/mozilla-central/rev/ed85d72cb6dd
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Updated•7 years ago
|
status-firefox55:
--- → unaffected
status-firefox56:
--- → unaffected
Comment 22•7 years ago
|
||
Hi Jim.
Sorry I forgot to mention this.
Maybe you'd like to show the background of DoorHanger like this bug
https://bugzilla.mozilla.org/show_bug.cgi?id=1352004
btw,
I used Dale's test site to test custom tab features. https://daleharvey.github.io/testapp/ . Maybe you already knew.
Flags: needinfo?(nchen)
Comment 23•7 years ago
|
||
Oh, CustomTabsActivity and WebAppActivity were similar at that time. But I'm not sure if it still the case now. Maybe that site won't help here. If the design now is different, please ignore it :)
Assignee | ||
Comment 24•7 years ago
|
||
Yeah we don't have the overlay for doorhangers in custom tabs / PWA. We can add that in a followup bug.
Flags: needinfo?(nchen)
Reporter | ||
Comment 25•7 years ago
|
||
Verified as fixed in build 57.0b9.
Devices: Motorola Nexus 6 (Android 7.1.1) and Sony Xperia Z5 Premium (Android 6.0.1).
Doorhanger is displayed following the steps from description and also for login page, geolocation.
Status: RESOLVED → VERIFIED
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•