Closed
Bug 1388756
Opened 7 years ago
Closed 7 years ago
The js::oom flags are now used for more than oom, so clean up
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: lth, Assigned: lth)
References
Details
Attachments
(1 file)
(deleted),
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
See bug 1379814 comment 9 for context. We should move the thread identifiers out of the js::oom namespace because they are generally useful and we use them for more than just OOM.
Assignee | ||
Comment 1•7 years ago
|
||
This moves the ThreadType from js::oom:: to js::, by shifting a little code in public/Utility.h, then cleans up all qualified references to omit the oom::.
I left the InitThreadType et al in the oom namespace since they really are no-ops except in certain testing modes, while the ThreadType is now used more generally.
Note, this sits on top of the pending patch for bug 1379814.
Compile-only try run is green:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3f36007198f91dbcfdd2e1b368f76719f6ffe91b
Attachment #8896208 -
Flags: review?(jcoppeard)
Updated•7 years ago
|
Attachment #8896208 -
Flags: review?(jcoppeard) → review+
Pushed by lhansen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/04f4df930678
Move helper thread types out of the OOM namespace. r=jonco
Comment 3•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•